Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6135001: Makes the in memory db update rows that have search terms associated (Closed)

Created:
9 years, 11 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Visibility:
Public.

Description

Makes the in memory db update rows that have search terms associated with them. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70777

Patch Set 1 #

Patch Set 2 : Improve comments and forward declare #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -6 lines) Patch
M chrome/browser/history/history_types.h View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 2 chunks +10 lines, -1 line 1 comment Download
M chrome/browser/history/url_database.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/history/url_database.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/history/url_database_unittest.cc View 1 chunk +15 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
9 years, 11 months ago (2011-01-06 20:41:41 UTC) #1
brettw
http://codereview.chromium.org/6135001/diff/2001/chrome/browser/history/in_memory_history_backend.cc File chrome/browser/history/in_memory_history_backend.cc (right): http://codereview.chromium.org/6135001/diff/2001/chrome/browser/history/in_memory_history_backend.cc#newcode94 chrome/browser/history/in_memory_history_backend.cc:94: HasKeyword(visited_details->row.url())) { Doesn't the row here have the keyword ...
9 years, 11 months ago (2011-01-06 20:43:34 UTC) #2
sky
On Thu, Jan 6, 2011 at 12:43 PM, <brettw@chromium.org> wrote: > > http://codereview.chromium.org/6135001/diff/2001/chrome/browser/history/in_memory_history_backend.cc > File ...
9 years, 11 months ago (2011-01-06 20:47:26 UTC) #3
brettw
9 years, 11 months ago (2011-01-07 18:18:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698