Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/grit/grit/format/policy_templates/template_formatter.py

Issue 6134006: Integrate user strings into the JSON policy template file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: " Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/grit/grit/format/policy_templates/template_formatter.py
diff --git a/tools/grit/grit/format/policy_templates/template_formatter.py b/tools/grit/grit/format/policy_templates/template_formatter.py
index 4fd28ebc3221eddf46b08cb391260f999f9af200..0e304afd1d6d5b3e59551cf80b6cdf459e4fef29 100644
--- a/tools/grit/grit/format/policy_templates/template_formatter.py
+++ b/tools/grit/grit/format/policy_templates/template_formatter.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2010 The Chromium Authors. All rights reserved.
+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
@@ -75,34 +75,12 @@ class TemplateFormatter(interface.ItemFormatter):
to __init__() and Format().
'''
policy_generator = policy_template_generator.PolicyTemplateGenerator(
- self._messages,
- self._policy_data['policy_definitions'])
- writer = self._writer_module.GetWriter(self._config, self._messages)
+ self._config,
+ self._policy_data)
+ writer = self._writer_module.GetWriter(self._config)
str = policy_generator.GetTemplateText(writer)
return str
- def _ImportMessage(self, message):
- '''Takes a grit message node and adds its translated content to
- self._messages.
-
- Args:
- message: A <message> node in the grit tree.
- '''
- msg_name = message.GetTextualIds()[0]
- # Get translation of message.
- msg_txt = message.Translate(self._lang)
- # Replace the placeholder of app name.
- msg_txt = msg_txt.replace('$1', self._config['app_name'])
- msg_txt = msg_txt.replace('$3', self._config['frame_name'])
- # Replace other placeholders.
- for placeholder in self._policy_data['placeholders']:
- msg_txt = msg_txt.replace(placeholder['key'], placeholder['value'])
- # Strip spaces and escape newlines.
- lines = msg_txt.split('\n')
- lines = [line.strip() for line in lines]
- msg_txt = "\n".join(lines)
- self._messages[msg_name] = msg_txt
-
def _ParseGritNodes(self, item):
'''Collects the necessary information from the grit tree:
the message strings and the policy definitions.
@@ -116,8 +94,7 @@ class TemplateFormatter(interface.ItemFormatter):
if (isinstance(item, structure.StructureNode) and
item.attrs['type'] == 'policy_template_metafile'):
assert self._policy_data == None
- self._policy_data = item.gatherer.GetData()
- elif (isinstance(item, message.MessageNode)):
- self._ImportMessage(item)
+ json_text = item.gatherer.Translate(self._lang)
+ self._policy_data = eval(json_text)
for child in item.children:
self._ParseGritNodes(child)

Powered by Google App Engine
This is Rietveld 408576698