tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py - Issue 6134006: Integrate user strings into the JSON policy template file

Unified Diff: tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py

Issue 6134006: Integrate user strings into the JSON policy template file (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: " Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/grit/grit/format/policy_templates/writers/reg_writer.py ('k') | tools/grit/grit/format/policy_templates/writers/template_writer.py » ('j') | tools/grit/grit/gather/policy_json.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py

diff --git a/tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py b/tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py

index 9cb9db73dfbd193edfe170d1cfb663586ac63d9e..2a1763048dcde03dd03b68f89e9ef92f4506d26e 100644

--- a/tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py

+++ b/tools/grit/grit/format/policy_templates/writers/reg_writer_unittest.py

@@ -42,7 +42,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

'{'

' "policy_definitions": [],'

' "placeholders": [],'

- '}', '<messages></messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_chromium': '1',}, 'reg', 'en')

expected_output = 'Windows Registry Editor Version 5.00'

self.CompareOutputs(output, expected_output)

@@ -55,6 +56,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "MainPolicy",'

' "type": "main",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.win:8-"],'

' "annotations": {'

' "example_value": True'

@@ -62,11 +65,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_MAINPOLICY_CAPTION"></message>'

- ' <message name="IDS_POLICY_MAINPOLICY_DESC"></message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_google_chrome' : '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00',

@@ -83,6 +83,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "StringPolicy",'

' "type": "string",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.win:8-"],'

' "annotations": {'

' "example_value": "hello, world! \\\" \\\\"'

@@ -90,11 +92,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_STRINGPOLICY_CAPTION"></message>'

- ' <message name="IDS_POLICY_STRINGPOLICY_DESC"></message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_chromium' : '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00',

@@ -111,9 +110,11 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "EnumPolicy",'

' "type": "enum",'

+ ' "caption": "",'

+ ' "desc": "",'

' "items": ['

- ' {"name": "ProxyServerDisabled", "value": 0},'

- ' {"name": "ProxyServerAutoDetect", "value": 1},'

+ ' {"name": "ProxyServerDisabled", "value": 0, "caption": ""},'

+ ' {"name": "ProxyServerAutoDetect", "value": 1, "caption": ""},'

' ],'

' "supported_on": ["chrome.win:8-"],'

' "annotations": {'

@@ -122,15 +123,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_ENUMPOLICY_CAPTION"></message>'

- ' <message name="IDS_POLICY_ENUMPOLICY_DESC"></message>'

- ' <message name="IDS_POLICY_ENUM_PROXYSERVERDISABLED_CAPTION">'

- ' </message>'

- ' <message name="IDS_POLICY_ENUM_PROXYSERVERAUTODETECT_CAPTION">'

- ' </message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_google_chrome': '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00',

@@ -147,6 +141,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "ListPolicy",'

' "type": "list",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.linux:8-"],'

' "annotations": {'

' "example_value": ["foo", "bar"]'

@@ -154,12 +150,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_LISTPOLICY_DESC"></message>'

- ' <message name="IDS_POLICY_LISTPOLICY_CAPTION"></message>'

- ' <message name="IDS_POLICY_LISTPOLICY_LABEL"></message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_chromium' : '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00',

@@ -177,6 +169,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "NonWindowsPolicy",'

' "type": "list",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.mac:8-"],'

' "annotations": {'

' "example_value": ["a"]'

@@ -184,11 +178,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_NONWINDOWSPOLICY_CAPTION"></message>'

- ' <message name="IDS_POLICY_NONWINDOWSPOLICY_DESC"></message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_chromium' : '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00'])

@@ -202,9 +193,13 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' {'

' "name": "Group1",'

' "type": "group",'

+ ' "caption": "",'

+ ' "desc": "",'

' "policies": [{'

' "name": "Policy1",'

' "type": "list",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.win:8-"],'

' "annotations": {'

' "example_value": ["a", "b"]'

@@ -212,6 +207,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },{'

' "name": "Policy2",'

' "type": "string",'

+ ' "caption": "",'

+ ' "desc": "",'

' "supported_on": ["chrome.win:8-"],'

' "annotations": {'

' "example_value": "c"'

@@ -220,15 +217,8 @@ class RegWriterUnittest(writer_unittest_common.WriterUnittestCommon):

' },'

' ],'

' "placeholders": [],'

- '}',

- '<messages>'

- ' <message name="IDS_POLICY_GROUP1_CAPTION"></message>'

- ' <message name="IDS_POLICY_GROUP1_DESC"></message>'

- ' <message name="IDS_POLICY_POLICY1_DESC"></message>'

- ' <message name="IDS_POLICY_POLICY2_DESC"></message>'

- ' <message name="IDS_POLICY_POLICY1_CAPTION"></message>'

- ' <message name="IDS_POLICY_POLICY2_CAPTION"></message>'

- '</messages>')

+ ' "messages": {},'

+ '}')

output = self.GetOutput(grd, 'fr', {'_chromium' : '1'}, 'reg', 'en')

expected_output = self.NEWLINE.join([

'Windows Registry Editor Version 5.00',