Issue 6134005: Revert 6220 (generic descriptor support in Object.defineOwnProperty)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6134005: Revert 6220 (generic descriptor support in Object.defineOwnProperty)... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Revert 6220 (generic descriptor support in Object.defineOwnProperty) This change caused a webkit failure in http/tests/security/xss-DENIED-defineProperty.html. I will look into this and reapply when I find a solution. Committed: http://code.google.com/p/v8/source/detail?r=6232

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -110 lines)			Patch
M	src/runtime.cc	View	2 chunks	+1 line, -12 lines	0 comments	Download
M	src/v8natives.js	View	4 chunks	+31 lines, -58 lines	0 comments	Download
M	test/mjsunit/object-define-property.js	View	2 chunks	+2 lines, -40 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages