Prototype of chunked transfer encoded POST.

net/url_request/url_request.h

Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index 3561a294624dccccc8eeb5d653a794eb13b10034..879c1bd441da60165e2dc98969a64dbbfcf9cc0a 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -312,6 +312,14 @@ class URLRequest : public base::NonThreadSafe {
     AppendFileRangeToUpload(file_path, 0, kuint64max, base::Time());
   }
 
+  // Appends the given bytes to the requests's POST data and adds an indication
+  // that more is to come. This is useful when the POST data is not available

[wtc, 2011/01/12 02:39:02]

I think "more is to come" is less useful info than "send the
chunk to the server immediately", so this comment could be
improved.

Document the MarkEndOfChunks method.  Alternatively, just
use a AppendChunkToUpload(NULL, 0) call to mark the end of
chunks.

Compared with the AppendXXXToUpload methods above, it's
important to point out that AppendChunkToUpload may only
be called after Start() is called.

Also, since you have a chunked_transfer_upload_ mode, why
don't you just reuse the existing AppendBytesToUpload method
to append a chunk?

[Satish, 2011/01/13 17:43:27]

Done
Documented. I prefer to not reuse AppendChunkToUpload with those magic values
since that requires the caller to know how the POST body is encoded.
Done
UploadData is the one which does the encoding of the chunks, prefixing them with
length+cr+lf and appending them with cr+lf. I've kept all other classes as
agnostic to the POST body format as possible.

+  // upfront when establishing the connection and as the data becomes available
+  // it can be sent to the server.
+  // This method should be called ONLY after calling Start().
+  void AppendChunkToUpload(const char* bytes, int bytes_len);
+  void MarkEndOfChunks();
+
   // Set the upload data directly.
   void set_upload(net::UploadData* upload);
 
@@ -429,6 +437,8 @@ class URLRequest : public base::NonThreadSafe {
   int load_flags() const { return load_flags_; }
   void set_load_flags(int flags) { load_flags_ = flags; }
 
+  void set_chunked_transfer_upload() { chunked_transfer_upload_ = true; }
+
   // Returns true if the request is "pending" (i.e., if Start() has been called,
   // and the response has not yet been called).
   bool is_pending() const { return is_pending_; }
@@ -626,6 +636,10 @@ class URLRequest : public base::NonThreadSafe {
   // Whether to enable performance profiling on the job serving this request.
   bool enable_profiling_;
 
+  // Whether the upload data contains chunks of data (sent via
+  // Chunked-Transfer encoding).
+  bool chunked_transfer_upload_;

[wtc, 2011/01/12 02:39:02]

Nit: shorten this to chunked_upload_ (and the setter to
set_chunked_upload).

[Satish, 2011/01/13 17:43:27]

Done.

+
   // Number of times we're willing to redirect.  Used to guard against
   // infinite redirects.
   int redirect_limit_;