Prototype of chunked transfer encoded POST.

net/http/http_stream_parser.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include "base/compiler_specific.h"
 #include "base/metrics/histogram.h"
 #include "net/base/auth.h"
 #include "net/base/io_buffer.h"
 #include "net/base/ssl_cert_request_info.h"
 #include "net/http/http_net_log_params.h"
 #include "net/http/http_request_headers.h"
+#include "net/base/load_flags.h"

[wtc, 2011/01/14 03:09:31]

Nit: remove this header.

[Satish, 2011/01/14 18:09:29]

Done.

 #include "net/http/http_request_info.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_util.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/socket/client_socket_handle.h"
 
 namespace net {
 
 HttpStreamParser::HttpStreamParser(ClientSocketHandle* connection,
                                    const HttpRequestInfo* request,
@@ skipping 36 matching lines @@
         NetLog::TYPE_HTTP_TRANSACTION_SEND_REQUEST_HEADERS,
         make_scoped_refptr(new NetLogHttpRequestParameter(
             request_line, headers)));
   }
   response_ = response;
   std::string request = request_line + headers.ToString();
   scoped_refptr<StringIOBuffer> headers_io_buf(new StringIOBuffer(request));
   request_headers_ = new DrainableIOBuffer(headers_io_buf,
                                            headers_io_buf->size());
   request_body_.reset(request_body);
+  if (request_body)

[wtc, 2011/01/14 03:09:31]

Nit: request_body => request_body_

[Satish, 2011/01/14 18:09:29]

Done.

+    request_body_->set_chunk_callback(this);

[vandebo (ex-Chrome), 2011/01/14 05:53:44]

set_chunk_callback will be called even when not using chunked encoding?  In that
case, would it be better to name it something else? 
UploadDataStream::set_data_consumer(...) ?

[Satish, 2011/01/14 18:09:29]

Changed now to only set for chunked streams

 
   io_state_ = STATE_SENDING_HEADERS;
   int result = DoLoop(OK);
   if (result == ERR_IO_PENDING)
     user_callback_ = callback;
 
   return result > 0 ? OK : result;
 }
 
 int HttpStreamParser::ReadResponseHeaders(CompletionCallback* callback) {
@@ skipping 56 matching lines @@
 
   // The client callback can do anything, including destroying this class,
   // so any pending callback must be issued after everything else is done.
   if (result != ERR_IO_PENDING && user_callback_) {
     CompletionCallback* c = user_callback_;
     user_callback_ = NULL;
     c->Run(result);
   }
 }
 
+void HttpStreamParser::OnChunkAvailable() {
+  OnIOComplete(0);

[wtc, 2011/01/14 03:09:31]

IMPORTANT: this should do nothing unless we're in the
STATE_SENDING_BODY state:
  if (io_state_ == STATE_SENDING_BODY)
    OnIOComplete(0);

An alternative solution is to move the call
  request_body_->set_chunk_callback(this);
from line 72 to line 248, when we transition into the
STATE_SENDING_BODY.

The problem is that when a new chunk is added, this class
may still be in the STATE_SENDING_HEADERS state.  If we
call OnIOComplete(0) without checking, we will be calling
DoSendHeaders.

[vandebo (ex-Chrome), 2011/01/14 05:53:44]

Indeed, this mustn't do anything unless io_state == STATE_SENDING_BODY

[Satish, 2011/01/14 18:09:29]

Done.

[Satish, 2011/01/14 18:09:29]

Done.

+}
+
 int HttpStreamParser::DoLoop(int result) {
   bool can_do_more = true;
   do {
     switch (io_state_) {
       case STATE_SENDING_HEADERS:
         if (result < 0)
           can_do_more = false;
         else
           result = DoSendHeaders(result);
         break;
@@ skipping 73 matching lines @@
         } else {
           coalesce = NO_ADVANTAGE;
         }
       }
       UMA_HISTOGRAM_ENUMERATION("Net.CoalescePotential", coalesce,
                                 COALESCE_POTENTIAL_MAX);
     }
     result = connection_->socket()->Write(request_headers_,
                                           bytes_remaining,
                                           &io_callback_);
-  } else if (request_body_ != NULL && request_body_->size()) {
+  } else if (request_body_ != NULL &&
+             (request_body_->is_chunked() || request_body_->size())) {
     io_state_ = STATE_SENDING_BODY;
     result = OK;
   } else {
     io_state_ = STATE_REQUEST_SENT;
   }
   return result;
 }
 
 int HttpStreamParser::DoSendBody(int result) {
   if (result > 0)
     request_body_->DidConsume(result);
 
   if (!request_body_->eof()) {
     int buf_len = static_cast<int>(request_body_->buf_len());
-    result = connection_->socket()->Write(request_body_->buf(), buf_len,
-                                          &io_callback_);
+    if (buf_len) {
+      result = connection_->socket()->Write(request_body_->buf(), buf_len,
+                                            &io_callback_);
+    } else {
+      // More POST data is to come hence wait for the callback.
+      result = ERR_IO_PENDING;
+    }
   } else {
     io_state_ = STATE_REQUEST_SENT;
   }
   return result;
 }
 
 int HttpStreamParser::DoReadHeaders() {
   io_state_ = STATE_READ_HEADERS_COMPLETE;
 
   // Grow the read buffer if necessary.
@@ skipping 364 matching lines @@
 void HttpStreamParser::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   if (request_->url.SchemeIs("https") && connection_->socket()) {
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLCertRequestInfo(cert_request_info);
   }
 }
 
 }  // namespace net