Prototype of chunked transfer encoded POST.

net/base/upload_data.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_UPLOAD_DATA_H_
 #define NET_BASE_UPLOAD_DATA_H_
 #pragma once
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "base/ref_counted.h"
 #include "googleurl/src/gurl.h"
+#include "net/base/completion_callback.h"
 #include "base/time.h"
 
 namespace net {
 
 class FileStream;
 
 class UploadData : public base::RefCounted<UploadData> {
  public:
   enum Type {
     TYPE_BYTES,
+    TYPE_CHUNK,  // Indicates that more data is to come.

[wtc, 2011/01/12 02:39:02]

The more important info is "send the data immediately".

[Satish, 2011/01/13 17:43:27]

Done.

     TYPE_FILE,
     TYPE_BLOB
   };
 
   class Element {
    public:
     Element();
     ~Element();
 
     Type type() const { return type_; }
@@ skipping 29 matching lines @@
       expected_file_modification_time_ = expected_modification_time;
     }
 
     // TODO(jianli): UploadData should not contain any blob reference. We need
     // to define another structure to represent WebKit::WebHTTPBody.
     void SetToBlobUrl(const GURL& blob_url) {
       type_ = TYPE_BLOB;
       blob_url_ = blob_url;
     }
 
+    void SetToChunk(const char* bytes, int bytes_len);
+
     // Returns the byte-length of the element.  For files that do not exist, 0
     // is returned.  This is done for consistency with Mozilla.
     // Once called, this function will always return the same value.
     uint64 GetContentLength();
 
     // Returns a FileStream opened for reading for this element, positioned at
     // |file_range_offset_|.  The caller gets ownership and is responsible
     // for cleaning up the FileStream. Returns NULL if this element is not of
     // type TYPE_FILE or if the file is not openable.
     FileStream* NewFileStreamForReading();
@@ skipping 27 matching lines @@
   void AppendBytes(const char* bytes, int bytes_len);
 
   void AppendFile(const FilePath& file_path);
 
   void AppendFileRange(const FilePath& file_path,
                        uint64 offset, uint64 length,
                        const base::Time& expected_modification_time);
 
   void AppendBlob(const GURL& blob_url);
 
+  void AppendChunk(const char* bytes, int bytes_len);
+
+  // Sets the callback to be invoked when new data is available to upload.
+  void set_data_callback(CompletionCallback* callback);

[wtc, 2011/01/12 02:39:02]

Rename this method set_chunk_callback and the member
chunk_callback_.

[Satish, 2011/01/13 17:43:27]

Done.

+
+  // Iniitalizes the object to receive chunks of upload data over time rather
+  // than all at once at connection time.

[wtc, 2011/01/12 02:39:02]

The UploadData class doesn't know about the connection, so
it is confusing to mention connection time here.

[Satish, 2011/01/13 17:43:27]

Done.

+  void set_is_chunked(bool set) { is_chunked_ = set; }
+  bool is_chunked() { return is_chunked_; }
+
   // Returns the total size in bytes of the data to upload.
   uint64 GetContentLength();
 
   std::vector<Element>* elements() {
     return &elements_;
   }
 
   void SetElements(const std::vector<Element>& elements);
 
   void swap_elements(std::vector<Element>* elements) {
     elements_.swap(*elements);
   }
 
   // Identifies a particular upload instance, which is used by the cache to
   // formulate a cache key.  This value should be unique across browser
   // sessions.  A value of 0 is used to indicate an unspecified identifier.
   void set_identifier(int64 id) { identifier_ = id; }
   int64 identifier() const { return identifier_; }
 
  private:
   friend class base::RefCounted<UploadData>;
 
   ~UploadData();
 
   std::vector<Element> elements_;
   int64 identifier_;
+  CompletionCallback* data_callback_;
+  bool is_chunked_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadData);
 };
 
 #if defined(UNIT_TEST)
 inline bool operator==(const UploadData::Element& a,
                        const UploadData::Element& b) {
   if (a.type() != b.type())
     return false;
   if (a.type() == UploadData::TYPE_BYTES)
@@ skipping 12 matching lines @@
 
 inline bool operator!=(const UploadData::Element& a,
                        const UploadData::Element& b) {
   return !(a == b);
 }
 #endif  // defined(UNIT_TEST)
 
 }  // namespace net
 
 #endif  // NET_BASE_UPLOAD_DATA_H_