Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 6133004: Fix for builder. (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, vandebo (ex-Chrome)
Visibility:
Public.

Description

Fix for builder. BUG=9911 TEST=compiles, works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/about_chrome_view.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
vandebo fyi TBR=evan
9 years, 11 months ago (2011-01-07 22:56:24 UTC) #1
Evan Martin
LGTM yep these things happen all the time On Fri, Jan 7, 2011 at 2:56 ...
9 years, 11 months ago (2011-01-07 22:57:17 UTC) #2
Avi (use Gerrit)
9 years, 11 months ago (2011-01-07 23:02:17 UTC) #3
After killing the release builders I started running the changes on the
release trybots. Oops #1: there is no release ChromeOS trybot. I grepped for
GetString. Oops #2: I didn't grep for GetStringF (I did this time; this was
the only one).

I'm feeling fine tho.

Powered by Google App Engine
This is Rietveld 408576698