Issue 6132008: Address clang complaint about needed parenthesis on logicals....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6132008: Address clang complaint about needed parenthesis on logicals.... (Closed)

Created:
9 years, 11 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Address clang complaint about needed parenthesis on logicals. BUG=None TEST=None TBR=thakis Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71070

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 11 months ago (2011-01-11 19:55:20 UTC) #2

LG

On Tue, Jan 11, 2011 at 11:54 AM,  <mrossetti@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Address clang complaint about needed parenthesis on logicals.
>
> BUG=None
> TEST=None
> TBR=thakis
>
>
> Please review this at http://codereview.chromium.org/6132008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
>
>
> Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> ===================================================================
> --- chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> (revision 71059)
> +++ chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
> (working copy)
> @@ -842,8 +842,8 @@
>  }
>
>  - (CGFloat)determineFinalScrollDelta:(CGFloat)delta {
> -  if (delta > 0.0 && ![scrollUpArrowView_ isHidden] ||
> -      delta < 0.0 && ![scrollDownArrowView_ isHidden]) {
> +  if ((delta > 0.0 && ![scrollUpArrowView_ isHidden]) ||
> +      (delta < 0.0 && ![scrollDownArrowView_ isHidden])) {
>     NSWindow* window = [self window];
>     NSRect windowFrame = [window frame];
>     NSScreen* screen = [window screen];
>
>
>

Expand Messages | Collapse Messages