Issue 6130004: The UMA stat for the Wrench menu was only firing when Alt+F was pressed, not ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6130004: The UMA stat for the Wrench menu was only firing when Alt+F was pressed, not ... (Closed)

Created:
9 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The UMA stat for the Wrench menu was only firing when Alt+F was pressed, not when mouse clicking. Move the recording of the event down into the funnel. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71029

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/wrench_menu_controller.mm	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/wrench_menu.cc	View		3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/6130004/diff/1/chrome/browser/ui/views/wrench_menu.cc File chrome/browser/ui/views/wrench_menu.cc (right): http://codereview.chromium.org/6130004/diff/1/chrome/browser/ui/views/wrench_menu.cc#newcode593 chrome/browser/ui/views/wrench_menu.cc:593: UserMetrics::RecordAction(UserMetricsAction("ShowAppMenu")); This only handles windows.

9 years, 11 months ago (2011-01-10 16:03:05 UTC) #2

Finnur

Take another look? On 2011/01/10 16:03:05, sky wrote: > http://codereview.chromium.org/6130004/diff/1/chrome/browser/ui/views/wrench_menu.cc > File chrome/browser/ui/views/wrench_menu.cc (right): > ...

9 years, 11 months ago (2011-01-11 00:05:02 UTC) #3

LGTM

Expand Messages | Collapse Messages