Issue 6130003: metrics: Add SendUserActionToUMA() to MetricsLibraryMock.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6130003: metrics: Add SendUserActionToUMA() to MetricsLibraryMock. (Closed)

Created:
9 years, 11 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/metrics.git@master

Visibility:
Public.

Description

metrics: Add SendUserActionToUMA() to MetricsLibraryMock. The metrics daemon doesn't support sending user actions, but I need this exposed through the mock library so I can use SendUserActionToUMA() in the power manager. Change-Id: Ie9e3995df9978768477fe46dcb9ebec4d1fff1d5 BUG=chromium-os:10696 TEST=built for x86-mario with FEATURES=test; checked that the power manager can now use SendUserActionToUMA() Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e258947

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	metrics_library.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	metrics_library_mock.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM Thanks for fixing this. Btw, I was just looking at this. That's a good ...

9 years, 11 months ago (2011-01-06 23:36:15 UTC) #2

Daniel Erat

9 years, 11 months ago (2011-01-06 23:45:37 UTC) #3

On Thu, Jan 6, 2011 at 3:36 PM,  <petkov@chromium.org> wrote:
> LGTM
>
> Thanks for fixing this. Btw, I was just looking at this. That's a good
> reason
> why inherited virtual methods should have a virtual keyword in the inherited
> declaration (per style, and the code currently doesn't follow it).

Or a compelling argument for C++ finally getting something like Java's
@Override already. :-P

(yeah, I know it's coming...)

> http://codereview.chromium.org/6130003/
>

Expand Messages | Collapse Messages