Issue 6128009: Pulling in newer gyp, nacl, and breakpad to bring together stronger gyp warni...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6128009: Pulling in newer gyp, nacl, and breakpad to bring together stronger gyp warni... (Closed)

Created:
9 years, 11 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
jeanluc, M-A Ruel, jeanluc1

CC:
chromium-reviews

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Pulling in newer gyp, nacl, and breakpad to bring together stronger gyp warnings with the fixes needed so we everything will stay green. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71137

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

http://codereview.chromium.org/6128009/diff/1/DEPS File DEPS (right): http://codereview.chromium.org/6128009/diff/1/DEPS#newcode4 DEPS:4: "googlecode_url": "https://%s.googlecode.com/svn", why https?

9 years, 11 months ago (2011-01-12 01:48:28 UTC) #3

bradn

9 years, 11 months ago (2011-01-12 01:51:08 UTC) #4

Ah, good catch!!!
I was lazy and did that instead of update .gclient.

That would have caused a world of pain if I landed it.

-BradN

On Tue, Jan 11, 2011 at 5:48 PM, <maruel@chromium.org> wrote:

>
> http://codereview.chromium.org/6128009/diff/1/DEPS
> File DEPS (right):
>
> http://codereview.chromium.org/6128009/diff/1/DEPS#newcode4
> DEPS:4: "googlecode_url": "https://%s.googlecode.com/svn",
> why https?
>
>
> http://codereview.chromium.org/6128009/
>

Expand Messages | Collapse Messages