Issue 6128008: X64 Crankshaft: Add LTemplatedInstruction and some derived classes to lithium...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6128008: X64 Crankshaft: Add LTemplatedInstruction and some derived classes to lithium... (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Add LTemplatedInstruction and some derived classes to lithium-x64.cc. Committed: http://code.google.com/p/v8/source/detail?r=6257

Patch Set 1 #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+173 lines, -43 lines)			Patch
M	src/ia32/lithium-ia32.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	6 chunks	+102 lines, -40 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	3 chunks	+67 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

9 years, 11 months ago (2011-01-11 11:23:20 UTC) #3

LGTM

http://codereview.chromium.org/6128008/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6128008/diff/1/src/x64/lithium-x64.cc#newcode76
src/x64/lithium-x64.cc:76: // environment()->PrintTo(stream);
What is this commented code?

http://codereview.chromium.org/6128008/diff/1/src/x64/lithium-x64.cc#newcode81
src/x64/lithium-x64.cc:81: //pointer_map()->PrintTo(stream);
Ditto?

Expand Messages | Collapse Messages