Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 6127003: Enable sharding of individual testsuites in tools/test.py... (Closed)

Created:
9 years, 11 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Enable sharding of individual testsuites in tools/test.py This patch enables two new flags for the tools/test.py script; --shard-count - giving the ability to split the tests to be run into shard-count chunks. --shard-run - giving the ability to specify which of the shards to actually run. Example tools/test.py -j15 --shard-count=2 --shard-run=1 mozilla would split the mozilla tests into two chunks and run the tests in the first chunk Running: tools/test.py -j15 --shard-count=2 --shard-run=1 mozilla tools/test.py -j15 --shard-count=2 --shard-run=2 mozilla is equivalent (in terms of test coverage) of just running: tools/test.py -j15 mozilla In addition, tests are now sorted before they are returned from the test specific ListTests methods (sputnik and mozilla tests where already sorted before they where returned). This change is needed to split a single test suite over two slaves on the waterfall. Committed: http://code.google.com/p/v8/source/detail?r=6248

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M test/cctest/testcfg.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/es5conform/testcfg.py View 1 chunk +2 lines, -0 lines 0 comments Download
M test/message/testcfg.py View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/testcfg.py View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/test.py View 1 2 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
9 years, 11 months ago (2011-01-10 13:33:54 UTC) #1
Mads Ager (chromium)
LGTm http://codereview.chromium.org/6127003/diff/2001/tools/test.py File tools/test.py (right): http://codereview.chromium.org/6127003/diff/2001/tools/test.py#newcode1184 tools/test.py:1184: result.add_option("--shard-count", help="Split testsuites into this number of shards", ...
9 years, 11 months ago (2011-01-10 13:51:12 UTC) #2
Rico
9 years, 11 months ago (2011-01-10 13:54:24 UTC) #3
http://codereview.chromium.org/6127003/diff/2001/tools/test.py
File tools/test.py (right):

http://codereview.chromium.org/6127003/diff/2001/tools/test.py#newcode1184
tools/test.py:1184: result.add_option("--shard-count", help="Split testsuites
into this number of shards",
On 2011/01/10 13:51:12, Mads Ager wrote:
> Split over more lines like the other options?

Done.

Powered by Google App Engine
This is Rietveld 408576698