Issue 6126001: With the Mac App Store, we see that window controls are no longer tied to the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6126001: With the Mac App Store, we see that window controls are no longer tied to the... (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

With the Mac App Store, we see that window controls are no longer tied to the top of the window. Adjust ours downward so they have space to breathe. BUG=68746 TEST=window widgets are vertically centered Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70621

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	chrome/browser/ui/cocoa/framed_browser_window.h	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/framed_browser_window.mm	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/tab_strip_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

9 years, 11 months ago (2011-01-06 18:02:49 UTC) #2

LGTM

This looks less bad than I thought it would, although I’m still not really in
love with it. Whatever. You can always hide behind the “UI guy made me do it”
excuse.

Expand Messages | Collapse Messages