Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2826)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 6125003: Make ExtensionBrowserEventRouter owned by ExtensionService.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
===================================================================
--- chrome/browser/extensions/extension_service.cc (revision 70913)
+++ chrome/browser/extensions/extension_service.cc (working copy)
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/extension_service.h"
#include <algorithm>
+#include <set>
Erik does not do reviews 2011/01/12 00:31:54 I don't see anything new that uses this.
asargent_no_longer_on_chrome 2011/01/13 21:34:07 There's existing code that uses it - I noticed a w
#include "base/basictypes.h"
#include "base/command_line.h"
@@ -625,7 +626,8 @@
ExtensionHistoryEventRouter::GetInstance()->ObserveProfile(profile_);
ExtensionAccessibilityEventRouter::GetInstance()->ObserveProfile(profile_);
- ExtensionBrowserEventRouter::GetInstance()->Init(profile_);
+ browser_event_router_.reset(new ExtensionBrowserEventRouter(profile_));
+ browser_event_router_->Init();
ExtensionBookmarkEventRouter::GetInstance()->Observe(
profile_->GetBookmarkModel());
ExtensionCookiesEventRouter::GetInstance()->Init();
@@ -1380,6 +1382,7 @@
}
void ExtensionService::DestroyingProfile() {
+ browser_event_router_.reset();
pref_change_registrar_.RemoveAll();
profile_ = NULL;
toolbar_model_.DestroyingProfile();

Powered by Google App Engine
This is Rietveld 408576698