Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: chrome/browser/ui/views/browser_actions_container.cc

Issue 6125003: Make ExtensionBrowserEventRouter owned by ExtensionService.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/browser_actions_container.h" 5 #include "chrome/browser/views/browser_actions_container.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 466 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 } 477 }
478 478
479 void BrowserActionsContainer::OnBrowserActionExecuted( 479 void BrowserActionsContainer::OnBrowserActionExecuted(
480 BrowserActionButton* button, 480 BrowserActionButton* button,
481 bool inspect_with_devtools) { 481 bool inspect_with_devtools) {
482 ExtensionAction* browser_action = button->browser_action(); 482 ExtensionAction* browser_action = button->browser_action();
483 483
484 // Popups just display. No notification to the extension. 484 // Popups just display. No notification to the extension.
485 // TODO(erikkay): should there be? 485 // TODO(erikkay): should there be?
486 if (!button->IsPopup()) { 486 if (!button->IsPopup()) {
487 ExtensionBrowserEventRouter::GetInstance()->BrowserActionExecuted( 487 ExtensionService* service = profile_->GetExtensionService();
488 service->browser_event_router()->BrowserActionExecuted(
488 profile_, browser_action->extension_id(), browser_); 489 profile_, browser_action->extension_id(), browser_);
489 return; 490 return;
490 } 491 }
491 492
492 // If we're showing the same popup, just hide it and return. 493 // If we're showing the same popup, just hide it and return.
493 bool same_showing = popup_ && button == popup_button_; 494 bool same_showing = popup_ && button == popup_button_;
494 495
495 // Always hide the current popup, even if it's not the same. 496 // Always hide the current popup, even if it's not the same.
496 // Only one popup should be visible at a time. 497 // Only one popup should be visible at a time.
497 HidePopup(); 498 HidePopup();
(...skipping 596 matching lines...) Expand 10 before | Expand all | Expand 10 after
1094 AnimationEnded(resize_animation_.get()); 1095 AnimationEnded(resize_animation_.get());
1095 } 1096 }
1096 } 1097 }
1097 1098
1098 bool BrowserActionsContainer::ShouldDisplayBrowserAction( 1099 bool BrowserActionsContainer::ShouldDisplayBrowserAction(
1099 const Extension* extension) { 1100 const Extension* extension) {
1100 // Only display incognito-enabled extensions while in incognito mode. 1101 // Only display incognito-enabled extensions while in incognito mode.
1101 return (!profile_->IsOffTheRecord() || 1102 return (!profile_->IsOffTheRecord() ||
1102 profile_->GetExtensionService()->IsIncognitoEnabled(extension)); 1103 profile_->GetExtensionService()->IsIncognitoEnabled(extension));
1103 } 1104 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698