Issue 6125002: Allow the official target to be used for non-official builds....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6125002: Allow the official target to be used for non-official builds.... (Closed)

Created:
9 years, 11 months ago by nsylvain

Modified:
9 years, 7 months ago

Reviewers:
cmp_google, chase, eblake

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Allow the official target to be used for non-official builds. Make sure we include PDF only when it is available. (It is not available on the normal non-official builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70698

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	build/all.gyp	View	1	2 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

eblake

LGTM http://codereview.chromium.org/6125002/diff/1/build/all.gyp File build/all.gyp (right): http://codereview.chromium.org/6125002/diff/1/build/all.gyp#newcode412 build/all.gyp:412: '../third_party/adobe/flash/flash_player.gyp:flash_player', tab?

9 years, 11 months ago (2011-01-07 00:17:47 UTC) #2

nsylvain

On Thu, Jan 6, 2011 at 4:17 PM, <eblake@google.com> wrote: > LGTM > > > ...

9 years, 11 months ago (2011-01-07 00:29:10 UTC) #3

lgtm

Expand Messages | Collapse Messages