Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2801)

Unified Diff: chrome/browser/tabs/tab_strip_model.cc

Issue 6124009: Adds some debugging code in hopes of figuring out why we're (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tabs/tab_strip_model_order_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tabs/tab_strip_model.cc
diff --git a/chrome/browser/tabs/tab_strip_model.cc b/chrome/browser/tabs/tab_strip_model.cc
index c127254aa290e66c388b7f53e87b583ef093fd23..5e877c13a615337574ff3894aaf5c99135c829d1 100644
--- a/chrome/browser/tabs/tab_strip_model.cc
+++ b/chrome/browser/tabs/tab_strip_model.cc
@@ -209,7 +209,12 @@ TabContentsWrapper* TabStripModel::DetachTabContentsAt(int index) {
DCHECK(ContainsIndex(index));
TabContentsWrapper* removed_contents = GetContentsAt(index);
- int next_selected_index = order_controller_->DetermineNewSelectedIndex(index);
+ // TODO(sky): nuke reason and old_data when we figure out what is causing
+ // 34135.
+ volatile int reason = 0;
+ int next_selected_index =
+ order_controller_->DetermineNewSelectedIndex(index, &reason);
+ volatile TabContentsData old_data = *contents_data_.at(index);
delete contents_data_.at(index);
contents_data_.erase(contents_data_.begin() + index);
if (empty())
« no previous file with comments | « no previous file | chrome/browser/tabs/tab_strip_model_order_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698