tko/parsers/version_1.py - Issue 6124004: Revert "Merge remote branch 'cros/upstream' into autotest-rebase"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tko/parsers/version_1.py

Issue 6124004: Revert "Merge remote branch 'cros/upstream' into autotest-rebase" (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/autotest.git@master

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tko/parsers/version_1.py

diff --git a/tko/parsers/version_1.py b/tko/parsers/version_1.py

index 7448c4fd28575083e1a0aee83ce57c37f569c999..111f7efaf6ade54bcbb98bf648c838be939bf96c 100644

--- a/tko/parsers/version_1.py

+++ b/tko/parsers/version_1.py

@@ -70,14 +70,11 @@ class iteration(models.iteration):

val_type = "perf"

# parse the actual value into a dict

- try:

- if val_type == "attr":

- attr_dict[key] = value

- elif val_type == "perf":

- perf_dict[key] = float(value)

- else:

- raise ValueError

- except ValueError:

+ if val_type == "attr":

+ attr_dict[key] = value

+ elif val_type == "perf" and re.search("^\d+(\.\d+)?$", value):

+ perf_dict[key] = float(value)

+ else:

msg = ("WARNING: line '%s' found in test "

"iteration keyval could not be parsed")

msg %= line

« no previous file with comments | « tko/job_serializer_unittest.py ('k') | tko/parsers/version_1_unittest.py » ('j') | no next file with comments »