Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 6124002: Re-land of http://codereview.chromium.org/6094009 with Mac build fix.... (Closed)

Created:
9 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Re-land of http://codereview.chromium.org/6094009 with Mac build fix. Perform GPU-related initialization in GPU process in response to an IPC from the browser. Because Chromium's child process host detects that the child has crashed by watching for IPC channel errors, it is imperative that the GPU process's IPC channel be set up before it does any work that might cause it to crash. If initialization fails, the GPU process quits its message loop and cooperatively exits. Fixed a bug in the GpuProcessHost where it would not unblock renderers waiting for GPU process initialization if the GPU process exited. BUG=65369 TEST=ran test case from bug on machine with no GPU hardware and verified that it no longer hangs the renderer, and that the GPU process exits Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -104 lines) Patch
M chrome/browser/gpu_process_host.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gpu_process_host.cc View 4 chunks +26 lines, -4 lines 0 comments Download
M chrome/common/gpu_messages_internal.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/gpu/gpu_main.cc View 4 chunks +9 lines, -80 lines 0 comments Download
M chrome/gpu/gpu_thread.h View 4 chunks +10 lines, -1 line 0 comments Download
M chrome/gpu/gpu_thread.cc View 3 chunks +106 lines, -19 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698