Also delete plugin data when the cookies checkbox in the clear browsing data dialog is checked.

Also delete plugin data when the cookies checkbox in the clear browsing data dialog is checked.

BUG=58235
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71304

[Bernhard Bauer, 2011-01-11 16:28:27]

Please review. This supercedes http://codereview.chromium.org/5964008/, as we
decided to merge the two checkboxes. 

The interesting stuff is in chrome/browser/dom_ui/options and
chrome/browser/resources/options, the rest is mostly merging the two
preferences.

[Evan Stade, 2011-01-11 20:46:05]

I have a patch that reworks the clear browser data overlay based on the new
mocks (also fixes a bug to make it actually work). I am just waiting for try
results before landing it. I'll let you know when it's landed so you can sync
your changes. I'll hold off on review until then. Sorry for the conflict.

[Evan Stade, 2011-01-11 21:57:46]

committed it in r71090.

[Bernhard Bauer, 2011-01-12 12:31:42]

On 2011/01/11 21:57:46, Evan Stade wrote:
> committed it in r71090.

Ok, I rebased my CL. It now also correctly updates the UI state during the
deletion (it was still calling methods on ClearBrowserDataOverlay before).

[Evan Stade, 2011-01-12 19:20:30]

Have you seen the mock at
http://code.google.com/p/chromium/issues/detail?id=63843

[Bernhard Bauer, 2011-01-12 22:49:14]

On Wed, Jan 12, 2011 at 20:20,  <estade@chromium.org> wrote:
> Have you seen the mock at
> http://code.google.com/p/chromium/issues/detail?id=63843

With regards to clearing Flash data, the mock is outdated. We very
recently had some discussions about this with Jeff and some Adobe
people, and we decided to merge the checkboxes for clearing cookies
and plugin data (treating all kinds of local data the same).

> http://codereview.chromium.org/6122008/
>

[Evan Stade, 2011-01-12 23:14:47]

lgtm