Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 6122006: Cleanup: Remove unneeded includes of pref_names.h (Closed)

Created:
9 years, 11 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, stuartmorgan+watch_chromium.org, Ilya Sherman, dhollowa, ncarter (slow), idana, Erik does not do reviews, jam, darin-cc_chromium.org, garykac, brettw-cc_chromium.org, tim (not reviewing), Raghu Simha, pam+watch_chromium.org, awong, James Hawkins, Sergey Ulanov, Alpha Left Google, Aaron Boodman, dmac, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded includes of pref_names.h BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71283

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -75 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_dialog_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background_application_list_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background_mode_manager_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/background_mode_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_child_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_chewing_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_mozc_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_pinyin_config_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_page_sync_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
MM chrome/browser/extensions/external_policy_extension_provider.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/first_run/first_run_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/in_memory_history_backend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/page_info_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_data_remover_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/plugin_exceptions_table_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/plugin_service.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM chrome/browser/prefs/pref_change_registrar_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/remoting/remoting_resources_source.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sidebar/sidebar_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_change_processor.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.cc View 3 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_harness.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/tab_restore_uitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_menu_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmark_context_menu_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmark_editor_view_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/clear_data_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/clear_server_data.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/instant_confirm_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/options/fonts_languages_window_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_dragging_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/live_preferences_sync_test.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/live_sync/many_client_live_preferences_sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/live_sync/single_client_live_preferences_sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/live_sync/two_client_live_preferences_sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
9 years, 11 months ago (2011-01-11 19:42:02 UTC) #1
Elliot Glaysher
9 years, 11 months ago (2011-01-12 00:28:14 UTC) #2
Rubber stamp wo looking. Will be out this week.
On Jan 11, 2011 1:42 PM, <thestig@chromium.org> wrote:
> Reviewers: James Hawkins, Elliot Glaysher,
>
> Description:
> Cleanup: Remove unneeded includes of pref_names.h
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6122006/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> M chrome/browser/app_controller_mac.mm
> M chrome/browser/autofill/autofill_browsertest.cc
> M chrome/browser/autofill/autofill_cc_infobar_delegate.cc
> M chrome/browser/autofill/autofill_cc_infobar_win.cc
> M chrome/browser/autofill/autofill_dialog_mac.mm
> M chrome/browser/autofill/personal_data_manager_unittest.cc
> M chrome/browser/background_application_list_model.cc
> M chrome/browser/background_mode_manager_linux.cc
> M chrome/browser/background_mode_manager_unittest.cc
> M
> chrome/browser/bookmarks/bookmark_context_menu_controller_unittest.cc
> M chrome/browser/browser_about_handler.cc
> M chrome/browser/browser_child_process_host.cc
> M chrome/browser/chromeos/options/language_chewing_config_view.cc
> M chrome/browser/chromeos/options/language_mozc_config_view.cc
> M chrome/browser/chromeos/options/language_pinyin_config_view.cc
> M chrome/browser/chromeos/status/clock_menu_button.cc
> M chrome/browser/chromeos/status/clock_menu_button_browsertest.cc
> M chrome/browser/dom_ui/new_tab_page_sync_handler.cc
> M chrome/browser/download/download_manager.cc
> M chrome/browser/extensions/extension_host.cc
> MM chrome/browser/extensions/external_policy_extension_provider.cc
> M chrome/browser/first_run/first_run_gtk.cc
> M chrome/browser/first_run/first_run_win.cc
> M chrome/browser/gtk/bookmark_editor_gtk_unittest.cc
> M chrome/browser/history/in_memory_history_backend.cc
> M chrome/browser/page_info_model.cc
> M chrome/browser/plugin_data_remover_helper.cc
> M chrome/browser/plugin_exceptions_table_model_unittest.cc
> M chrome/browser/plugin_service.h
> M chrome/browser/plugin_service.cc
> MM chrome/browser/prefs/pref_change_registrar_unittest.cc
> M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc
> M chrome/browser/profiles/profile_manager.cc
> M chrome/browser/profiles/profile_manager_unittest.cc
> M chrome/browser/remoting/remoting_resources_source.cc
> M chrome/browser/sidebar/sidebar_manager.cc
> M chrome/browser/ssl/ssl_blocking_page.cc
> M chrome/browser/ssl/ssl_browser_tests.cc
> M chrome/browser/ssl/ssl_manager.cc
> M chrome/browser/ssl/ssl_policy.cc
> M chrome/browser/sync/glue/autofill_change_processor.cc
> M chrome/browser/sync/glue/autofill_model_associator.cc
> M chrome/browser/sync/glue/theme_util.cc
> M chrome/browser/sync/profile_sync_factory_impl.cc
> M chrome/browser/sync/profile_sync_service_harness.cc
> M chrome/browser/sync/profile_sync_service_session_unittest.cc
> M chrome/browser/tab_restore_uitest.cc
> M chrome/browser/tabs/tab_strip_model_unittest.cc
> M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
> M
> chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
> M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
> M chrome/browser/ui/tabs/tab_menu_model.cc
> M chrome/browser/ui/views/bookmark_context_menu_test.cc
> M chrome/browser/ui/views/bookmark_editor_view_unittest.cc
> M chrome/browser/ui/views/clear_data_view.cc
> M chrome/browser/ui/views/clear_server_data.cc
> M chrome/browser/ui/views/constrained_window_win.cc
> M chrome/browser/ui/views/instant_confirm_view.cc
> M chrome/browser/ui/views/options/fonts_languages_window_view.cc
> M chrome/browser/ui/views/tabs/tab_dragging_test.cc
> M chrome/browser/ui/views/tabs/tab_strip.cc
> M chrome/test/live_sync/live_preferences_sync_test.h
> M chrome/test/live_sync/many_client_live_preferences_sync_test.cc
> M chrome/test/live_sync/multiple_client_live_preferences_sync_test.cc
> M chrome/test/live_sync/single_client_live_preferences_sync_test.cc
> M chrome/test/live_sync/two_client_live_preferences_sync_test.cc
> M chrome/test/tab_switching/tab_switching_test.cc
>
>

Powered by Google App Engine
This is Rietveld 408576698