Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 6121007: Revert 71230 to see if it is related to hang on linux interactive_ui_tests.... (Closed)

Created:
9 years, 11 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 71230 to see if it is related to hang on linux interactive_ui_tests. Original CL description: Streamline the layout of the BrowserView's children TabContents views. Modify SingleSplitView to calculate its children view's bounds, but do not actually resize them and change BrowserViewLayout accordingly (BrowserViewLayout resizes all views now). Do all reserved contents rect calculations before resizing TabContents views. Rationale: to do all BrowserView layout related actions in the context of BrowserViewLayout::Layout call and to minimize actual contents re-layouts. BUG=51084 TEST=All tests should pass Review URL: http://codereview.chromium.org/5606012 TBR=alekseys@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -509 lines) Patch
M chrome/browser/ui/views/frame/browser_view.h View 6 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 11 chunks +47 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 3 chunks +1 line, -15 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 3 chunks +4 lines, -109 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.h View 4 chunks +20 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_container.cc View 7 chunks +22 lines, -18 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M views/controls/single_split_view.h View 5 chunks +6 lines, -52 lines 0 comments Download
M views/controls/single_split_view.cc View 6 chunks +51 lines, -96 lines 0 comments Download
D views/controls/single_split_view_unittest.cc View 1 chunk +0 lines, -176 lines 0 comments Download
M views/examples/single_split_view_example.h View 1 chunk +1 line, -2 lines 0 comments Download
M views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eroman
9 years, 11 months ago (2011-01-12 22:58:32 UTC) #1
eroman
9 years, 11 months ago (2011-01-12 22:58:43 UTC) #2
Aleksey Shlyapnikov
9 years, 11 months ago (2011-01-12 23:02:11 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698