Remove wstring from gfx.

Remove wstring from gfx.

BUG=68882
TEST=no visible changes; all tests pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71167

[evanm, 2011-01-11 21:56:46]

LGTM

http://codereview.chromium.org/6121004/diff/72001/chrome/browser/chromeos/dom...
File chrome/browser/chromeos/dom_ui/menu_ui.cc (right):

http://codereview.chromium.org/6121004/diff/72001/chrome/browser/chromeos/dom...
chrome/browser/chromeos/dom_ui/menu_ui.cc:45: // A utility function that
generates css font property from gfx::Font.
May wanna tag this as returning UTF-8, since we don't normally do that.  (There
are e.g. Japanese font names that can show up here, I think.)

http://codereview.chromium.org/6121004/diff/72001/gfx/platform_font.h
File gfx/platform_font.h (right):

http://codereview.chromium.org/6121004/diff/72001/gfx/platform_font.h#newcode61
gfx/platform_font.h:61: virtual const string16& GetFontName() const = 0;
Not your problem, but this really shoulda returned a plain wstring/string16, not
a ref

http://codereview.chromium.org/6121004/diff/72001/views/controls/label_unitte...
File views/controls/label_unittest.cc (right):

http://codereview.chromium.org/6121004/diff/72001/views/controls/label_unitte...
views/controls/label_unittest.cc:18: #if defined(WIN_OS)
This define is totally wrong :<

[Avi (use Gerrit), 2011-01-11 22:15:27]

Re-trybotting.

http://codereview.chromium.org/6121004/diff/72001/chrome/browser/chromeos/dom...
File chrome/browser/chromeos/dom_ui/menu_ui.cc (right):

http://codereview.chromium.org/6121004/diff/72001/chrome/browser/chromeos/dom...
chrome/browser/chromeos/dom_ui/menu_ui.cc:45: // A utility function that
generates css font property from gfx::Font.
On 2011/01/11 21:56:47, evanm wrote:
> May wanna tag this as returning UTF-8, since we don't normally do that. 
(There
> are e.g. Japanese font names that can show up here, I think.)

Good point.

http://codereview.chromium.org/6121004/diff/72001/gfx/platform_font.h
File gfx/platform_font.h (right):

http://codereview.chromium.org/6121004/diff/72001/gfx/platform_font.h#newcode61
gfx/platform_font.h:61: virtual const string16& GetFontName() const = 0;
On 2011/01/11 21:56:47, evanm wrote:
> Not your problem, but this really shoulda returned a plain wstring/string16,
not
> a ref

Done.

http://codereview.chromium.org/6121004/diff/72001/views/controls/label_unitte...
File views/controls/label_unittest.cc (right):

http://codereview.chromium.org/6121004/diff/72001/views/controls/label_unitte...
views/controls/label_unittest.cc:18: #if defined(WIN_OS)
On 2011/01/11 21:56:47, evanm wrote:
> This define is totally wrong :<

Oh wow. Let's trybot this again...

[evanm, 2011-01-11 22:19:14]

On Tue, Jan 11, 2011 at 2:15 PM,  <avi@chromium.org> wrote:
>> Not your problem, but this really shoulda returned a plain
>
> wstring/string16, not
>>
>> a ref
>
> Done.

Make sure to fix all of the overrides!  :\

>> This define is totally wrong :<
>
> Oh wow. Let's trybot this again...

Not your fault.

[Avi (use Gerrit), 2011-01-11 22:20:36]

On 2011/01/11 22:19:14, evanm wrote:
> Make sure to fix all of the overrides!  :\

Of course.

> Not your fault.

I know whose fault it is. Is it worth dropping him a line for a change he made
14 months ago?

[evanm, 2011-01-11 22:22:36]

On Tue, Jan 11, 2011 at 2:20 PM,  <avi@chromium.org> wrote:
> On 2011/01/11 22:19:14, evanm wrote:
>>
>> Make sure to fix all of the overrides!  :\
>
> Of course.
>
>> Not your fault.
>
> I know whose fault it is. Is it worth dropping him a line for a change he
> made
> 14 months ago?

Pre-LGTM with from me on the cahnge ;)