Issue 6121001: Crankshaft: Create platform-independent lithium files, move LGapResolver and LGapNode there.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6121001: Crankshaft: Create platform-independent lithium files, move LGapResolver and LGapNode there. (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Create platform-independent lithium files, move LGapResolver and LGapNode there Committed: http://code.google.com/p/v8/source/detail?r=6221

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+255 lines, -348 lines)			Patch
M	src/SConscript	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/arm/lithium-arm.h	View	1 2 3	3 chunks	+2 lines, -27 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2 3	2 chunks	+1 line, -146 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 2	4 chunks	+2 lines, -25 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 2	2 chunks	+1 line, -146 lines	0 comments	Download
A	src/lithium.h	View	1 2 3 4	1 chunk	+63 lines, -0 lines	0 comments	Download
A	src/lithium.cc	View	1	1 chunk	+179 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

9 years, 11 months ago (2011-01-07 10:38:11 UTC) #3

LGTM.

http://codereview.chromium.org/6121001/diff/27001/src/lithium.h
File src/lithium.h (right):

http://codereview.chromium.org/6121001/diff/27001/src/lithium.h#newcode31
src/lithium.h:31: //#include "hydrogen.h"
Remove the commented out code in the #includes.

Expand Messages | Collapse Messages