Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 6120003: Unit test for testing SSL client auth with both a proxy and an SSL endpoint (Closed)

Created:
9 years, 11 months ago by Ryan Sleevi
Modified:
9 years, 2 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., agl
Visibility:
Public.

Description

Unit test to demonstrate that you cannot (currently) use independent SSL client certificates with an HTTPS proxy connecting to an SSL server. BUG=59292 TEST=HttpNetworkTransactionTest.HTTPSProxyAuthAndSSLClientAuth

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -1 line) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +247 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 3 chunks +13 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
Ryan, Here's a unit test that builds on both http://codereview.chromium.org/6120002/ and http://codereview.chromium.org/6017010/ (again, due to ...
9 years, 11 months ago (2011-01-09 12:51:33 UTC) #1
Ryan Hamilton
Wow! Yuck! I think you've definitely uncovered a significant issue :( From reading your detailed ...
9 years, 11 months ago (2011-01-10 23:35:53 UTC) #2
Ryan Sleevi
Did you mean HttpNetworkTransaction (instead of HttpStreamRequest?) If so, I was thinking the same thing ...
9 years, 11 months ago (2011-01-10 23:45:31 UTC) #3
Ryan Sleevi
+cc wtc: In response to your comments on http://codereview.chromium.org/6120002/ The ssl_config_ of HttpStreamRequest/HttpNetworkTransaction is currently ...
9 years, 11 months ago (2011-01-11 23:33:22 UTC) #4
wtc
9 years, 11 months ago (2011-01-11 23:49:56 UTC) #5
rsleevi: this is a known weakness of using the same ssl_config
for the HTTPS proxy and destination server.

The solution is to have two ssl_config (at least the send_client_cert
and client_cert fields) structures, similar to the

  scoped_refptr<HttpAuthController>
      auth_controllers_[HttpAuth::AUTH_NUM_TARGETS];

member of HttpNetworkTransaction for HTTP proxy and server auth.

Powered by Google App Engine
This is Rietveld 408576698