Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: src/disassembler.cc

Issue 6120001: Fix disassembly comment for CallFunctionStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 ASSERT(obj->IsSmi()); 261 ASSERT(obj->IsSmi());
262 // Get the STUB key and extract major and minor key. 262 // Get the STUB key and extract major and minor key.
263 uint32_t key = Smi::cast(obj)->value(); 263 uint32_t key = Smi::cast(obj)->value();
264 uint32_t minor_key = CodeStub::MinorKeyFromKey(key); 264 uint32_t minor_key = CodeStub::MinorKeyFromKey(key);
265 CodeStub::Major major_key = CodeStub::GetMajorKey(code); 265 CodeStub::Major major_key = CodeStub::GetMajorKey(code);
266 ASSERT(major_key == CodeStub::MajorKeyFromKey(key)); 266 ASSERT(major_key == CodeStub::MajorKeyFromKey(key));
267 out.AddFormatted(" %s, %s, ", 267 out.AddFormatted(" %s, %s, ",
268 Code::Kind2String(kind), 268 Code::Kind2String(kind),
269 CodeStub::MajorName(major_key, false)); 269 CodeStub::MajorName(major_key, false));
270 switch (major_key) { 270 switch (major_key) {
271 case CodeStub::CallFunction: 271 case CodeStub::CallFunction: {
272 out.AddFormatted("argc = %d", minor_key); 272 int argc =
273 CallFunctionStub::ExtractArgcFromMinorKey(minor_key);
274 out.AddFormatted("argc = %d", argc);
273 break; 275 break;
274 default: 276 }
277 default:
275 out.AddFormatted("minor: %d", minor_key); 278 out.AddFormatted("minor: %d", minor_key);
276 } 279 }
277 } 280 }
278 } else { 281 } else {
279 out.AddFormatted(" %s", Code::Kind2String(kind)); 282 out.AddFormatted(" %s", Code::Kind2String(kind));
280 } 283 }
281 } else if (rmode == RelocInfo::RUNTIME_ENTRY) { 284 } else if (rmode == RelocInfo::RUNTIME_ENTRY) {
282 // A runtime entry reloinfo might be a deoptimization bailout. 285 // A runtime entry reloinfo might be a deoptimization bailout.
283 Address addr = relocinfo.target_address(); 286 Address addr = relocinfo.target_address();
284 int id = Deoptimizer::GetDeoptimizationId(addr, Deoptimizer::EAGER); 287 int id = Deoptimizer::GetDeoptimizationId(addr, Deoptimizer::EAGER);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 329
327 #else // ENABLE_DISASSEMBLER 330 #else // ENABLE_DISASSEMBLER
328 331
329 void Disassembler::Dump(FILE* f, byte* begin, byte* end) {} 332 void Disassembler::Dump(FILE* f, byte* begin, byte* end) {}
330 int Disassembler::Decode(FILE* f, byte* begin, byte* end) { return 0; } 333 int Disassembler::Decode(FILE* f, byte* begin, byte* end) { return 0; }
331 void Disassembler::Decode(FILE* f, Code* code) {} 334 void Disassembler::Decode(FILE* f, Code* code) {}
332 335
333 #endif // ENABLE_DISASSEMBLER 336 #endif // ENABLE_DISASSEMBLER
334 337
335 } } // namespace v8::internal 338 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698