Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 6119004: ARM: Implement delete operation in lithium codegen.... (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Implement delete operation in lithium codegen. I'm using the post call generator for the macro assembler InvokeBuiltin call to be consistent with the ia32 version. It only generates one call, but using the post call generator it should be easier to catch if we change that at some point. Committed: http://code.google.com/p/v8/source/detail?r=6247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 11 months ago (2011-01-10 12:06:47 UTC) #1
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-10 12:22:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698