Issue 6118002: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6118002: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test e... (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test expectations. Committed: http://code.google.com/p/v8/source/detail?r=6215

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -11 lines)			Patch
	M	src/x64/lithium-x64.h	View	1	3 chunks	+26 lines, -10 lines	0 comments	Download
	M	test/mjsunit/mjsunit.status	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h File src/x64/lithium-x64.h (right): http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h#newcode33 src/x64/lithium-x64.h:33: #include "lithium.h" Do we need this include?

9 years, 11 months ago (2011-01-07 09:36:07 UTC) #2

William Hesse

9 years, 11 months ago (2011-01-07 09:46:09 UTC) #3

http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h
File src/x64/lithium-x64.h (right):

http://codereview.chromium.org/6118002/diff/1/src/x64/lithium-x64.h#newcode33
src/x64/lithium-x64.h:33: #include "lithium.h"
On 2011/01/07 09:36:07, Rico wrote:
> Do we need this include?

This is part of a different changelist, and will be removed from this one. 
Done.

Expand Messages | Collapse Messages

Issue 6118002: X64 Crankshaft: Implement some methods in LInstruction, update mjsunit test e... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages