Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/objects.h

Issue 6118001: Avoid calling inherited setters when creating object literals and their boilerplates. (Closed)
Patch Set: Address review comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap-inl.h ('k') | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1323 matching lines...) Expand 10 before | Expand all | Expand 10 after
1334 MUST_USE_RESULT MaybeObject* SetProperty(String* key, 1334 MUST_USE_RESULT MaybeObject* SetProperty(String* key,
1335 Object* value, 1335 Object* value,
1336 PropertyAttributes attributes); 1336 PropertyAttributes attributes);
1337 MUST_USE_RESULT MaybeObject* SetProperty(LookupResult* result, 1337 MUST_USE_RESULT MaybeObject* SetProperty(LookupResult* result,
1338 String* key, 1338 String* key,
1339 Object* value, 1339 Object* value,
1340 PropertyAttributes attributes); 1340 PropertyAttributes attributes);
1341 MUST_USE_RESULT MaybeObject* SetPropertyWithFailedAccessCheck( 1341 MUST_USE_RESULT MaybeObject* SetPropertyWithFailedAccessCheck(
1342 LookupResult* result, 1342 LookupResult* result,
1343 String* name, 1343 String* name,
1344 Object* value); 1344 Object* value,
1345 bool check_prototype);
1345 MUST_USE_RESULT MaybeObject* SetPropertyWithCallback(Object* structure, 1346 MUST_USE_RESULT MaybeObject* SetPropertyWithCallback(Object* structure,
1346 String* name, 1347 String* name,
1347 Object* value, 1348 Object* value,
1348 JSObject* holder); 1349 JSObject* holder);
1349 MUST_USE_RESULT MaybeObject* SetPropertyWithDefinedSetter(JSFunction* setter, 1350 MUST_USE_RESULT MaybeObject* SetPropertyWithDefinedSetter(JSFunction* setter,
1350 Object* value); 1351 Object* value);
1351 MUST_USE_RESULT MaybeObject* SetPropertyWithInterceptor( 1352 MUST_USE_RESULT MaybeObject* SetPropertyWithInterceptor(
1352 String* name, 1353 String* name,
1353 Object* value, 1354 Object* value,
1354 PropertyAttributes attributes); 1355 PropertyAttributes attributes);
1355 MUST_USE_RESULT MaybeObject* SetPropertyPostInterceptor( 1356 MUST_USE_RESULT MaybeObject* SetPropertyPostInterceptor(
1356 String* name, 1357 String* name,
1357 Object* value, 1358 Object* value,
1358 PropertyAttributes attributes); 1359 PropertyAttributes attributes);
1359 MUST_USE_RESULT MaybeObject* IgnoreAttributesAndSetLocalProperty( 1360 MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributes(
1360 String* key, 1361 String* key,
1361 Object* value, 1362 Object* value,
1362 PropertyAttributes attributes); 1363 PropertyAttributes attributes);
1363 1364
1364 // Retrieve a value in a normalized object given a lookup result. 1365 // Retrieve a value in a normalized object given a lookup result.
1365 // Handles the special representation of JS global objects. 1366 // Handles the special representation of JS global objects.
1366 Object* GetNormalizedProperty(LookupResult* result); 1367 Object* GetNormalizedProperty(LookupResult* result);
1367 1368
1368 // Sets the property value in a normalized object given a lookup result. 1369 // Sets the property value in a normalized object given a lookup result.
1369 // Handles the special representation of JS global objects. 1370 // Handles the special representation of JS global objects.
(...skipping 5019 matching lines...) Expand 10 before | Expand all | Expand 10 after
6389 } else { 6390 } else {
6390 value &= ~(1 << bit_position); 6391 value &= ~(1 << bit_position);
6391 } 6392 }
6392 return value; 6393 return value;
6393 } 6394 }
6394 }; 6395 };
6395 6396
6396 } } // namespace v8::internal 6397 } } // namespace v8::internal
6397 6398
6398 #endif // V8_OBJECTS_H_ 6399 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « src/heap-inl.h ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698