Issue 6117005: Adds the x-nacl to the MIME types recognized by the Pepper NaCl plug-in. Anot...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6117005: Adds the x-nacl to the MIME types recognized by the Pepper NaCl plug-in. Anot... (Closed)

Created:
9 years, 11 months ago by bbudge

Modified:
9 years, 7 months ago

Reviewers:
noelallen_use_chromium, abarth-chromium

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds the x-nacl to the MIME types recognized by the Pepper NaCl plug-in. Another CL will remove the old MIME type (x-ppapi-nacl-srpc) after the NaCl tree has been updated, to avoid a window where NaCl is broken. BUG=none TESTS=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71094

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	chrome/common/pepper_plugin_registry.cc	View		2 chunks	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bbudge

As far as I can tell, currently the MIME type can be anything as long ...

9 years, 11 months ago (2011-01-11 00:55:52 UTC) #1

abarth-chromium

9 years, 11 months ago (2011-01-11 01:01:13 UTC) #2

LGTM!

http://codereview.chromium.org/6117005/diff/1/chrome/common/pepper_plugin_reg...
File chrome/common/pepper_plugin_registry.cc (right):

http://codereview.chromium.org/6117005/diff/1/chrome/common/pepper_plugin_reg...
chrome/common/pepper_plugin_registry.cc:26: "application/x-nacl";
Much nicer!

Expand Messages | Collapse Messages