Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 6114004: When hiding a plug-in element, also hide same-sized parent elements (such as... (Closed)

Created:
9 years, 11 months ago by Chris Evans
Modified:
9 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

When hiding a plug-in element, also hide same-sized parent elements (such as <div>s) -- this makes the underlying page clickable where previously it may not have been. BUG=63695 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71498

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M chrome/renderer/blocked_plugin.cc View 1 3 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
As previously discussed by mail. It's a pit of filth, but very well contained to ...
9 years, 11 months ago (2011-01-11 23:24:19 UTC) #1
Bernhard Bauer
9 years, 11 months ago (2011-01-14 15:53:10 UTC) #2
On 2011/01/11 23:24:19, Chris Evans wrote:
> As previously discussed by mail. It's a pit of filth, but very well contained
to
> a single, plugin-unhiding-specific file. It does the "right thing" in all
cases
> I've encountered over the past months (which I documented in the bug), so I
> think we should land this.
> With this in place, I'd say the feature works well enough to promote it to an
> "X" icon in the blocked plugin UI itself. I can look at that again if we land
> this.

As also discussed by mail, LGTM if you acknowledge the ugliness in a TODO ;-)

Powered by Google App Engine
This is Rietveld 408576698