Move launcher_.reset() from UITestBase constructor to SetUp().

chrome/test/ui/ui_test.cc

Index: chrome/test/ui/ui_test.cc
diff --git a/chrome/test/ui/ui_test.cc b/chrome/test/ui/ui_test.cc
index a2d658e0e611a2c5213e09422d68c5355cd0678c..c2c7b856a985539f369f86597d8e851497b4241b 100644
--- a/chrome/test/ui/ui_test.cc
+++ b/chrome/test/ui/ui_test.cc
@@ -93,7 +93,6 @@ UITestBase::UITestBase()
       shutdown_type_(ProxyLauncher::WINDOW_CLOSE) {
   PathService::Get(chrome::DIR_APP, &browser_directory_);
   PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory_);
-  launcher_.reset(CreateProxyLauncher());
 }
 
 UITestBase::UITestBase(MessageLoop::Type msg_loop_type)
@@ -110,12 +109,13 @@ UITestBase::UITestBase(MessageLoop::Type msg_loop_type)
       shutdown_type_(ProxyLauncher::WINDOW_CLOSE) {
   PathService::Get(chrome::DIR_APP, &browser_directory_);
   PathService::Get(chrome::DIR_TEST_DATA, &test_data_directory_);
-  launcher_.reset(CreateProxyLauncher());
 }
 
 UITestBase::~UITestBase() {}
 
 void UITestBase::SetUp() {
+  if (!launcher_.get())

[Paweł Hajdan Jr., 2011/01/12 21:34:29]

nit: Add a comment above why this NULL-check is needed.

For example: Some tests (SessionRestore...) call SetUp multiple times.
ProxyLauncher should only be created once.
// TODO(phajdan.jr): Fix tests that abuse SetUp and remove this check.

+    launcher_.reset(CreateProxyLauncher());
   launcher_->AssertAppNotRunning(L"Please close any other instances "
                                  L"of the app before testing.");