Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 6110006: give tabbed options clear browsing dialog a facelift (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: delete bugs Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/options.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 0734b6bce6ea7d68ff3309e4a58e5c6f7efa4a2a..2937335d4ad135eee3b8f732bb9e2feb1afd6d7d 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -280,7 +280,7 @@ cr.define('options', function() {
/////////////////////////////////////////////////////////////////////////////
// PrefSelect class:
- // Define a constructor that uses an select element as its underlying element.
+ // Define a constructor that uses a select element as its underlying element.
var PrefSelect = cr.ui.define('select');
PrefSelect.prototype = {
@@ -331,6 +331,9 @@ cr.define('options', function() {
// Listen to user events.
this.addEventListener('change',
function(e) {
+ if (!self.dataType)
+ console.error('unknown data type for <select> pref');
+
switch(self.dataType) {
case 'number':
Preferences.setIntegerPref(self.pref,
« no previous file with comments | « chrome/browser/resources/options/options.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698