give tabbed options clear browsing dialog a facelift

chrome/browser/resources/options/pref_ui.js

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var Preferences = options.Preferences;
   /////////////////////////////////////////////////////////////////////////////
   // PrefCheckbox class:
   // TODO(jhawkins): Refactor all this copy-pasted code!
@@ skipping 262 matching lines @@
     updateIndicator: function() {
       if ($(this.id + '-value')) {
         $(this.id + '-value').textContent = this.value;
       }
     }
   };
 
   /////////////////////////////////////////////////////////////////////////////
   // PrefSelect class:
 
-  // Define a constructor that uses an select element as its underlying element.
+  // Define a constructor that uses a select element as its underlying element.
   var PrefSelect = cr.ui.define('select');
 
   PrefSelect.prototype = {
     // Set up the prototype chain
     __proto__: HTMLSelectElement.prototype,
 
     /**
     * Initialization function for the cr.ui framework.
     */
     decorate: function() {
@@ skipping 30 matching lines @@
             if (!found)
               self.selectedIndex = 0;
 
             if (self.onchange != undefined)
               self.onchange(event);
           });
 
       // Listen to user events.
       this.addEventListener('change',
           function(e) {
+            if (!self.dataType)
+              console.error('unknown data type for <select> pref');
+
             switch(self.dataType) {
               case 'number':
                 Preferences.setIntegerPref(self.pref,
                     self.options[self.selectedIndex].value, self.metric);
                 break;
               case 'boolean':
                 var option = self.options[self.selectedIndex];
                 var value = (option.value == 'true') ? true : false;
                 Preferences.setBooleanPref(self.pref, value, self.metric);
                 break;
@@ skipping 80 matching lines @@
     PrefCheckbox: PrefCheckbox,
     PrefNumber: PrefNumber,
     PrefNumeric: PrefNumeric,
     PrefRadio: PrefRadio,
     PrefRange: PrefRange,
     PrefSelect: PrefSelect,
     PrefTextField: PrefTextField
   };
 
 });