Issue 6109003: Fix grit dependencies for chromeos, touchui, and toolkit_views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6109003: Fix grit dependencies for chromeos, touchui, and toolkit_views. (Closed)

Created:
9 years, 11 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix grit dependencies for chromeos, touchui, and toolkit_views. We weren't passing in the grit defines to grit_info.py, so we weren't getting the dependencies behind <if> blocks included in the Makefile. BUG=68028 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70822

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	app/app.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/default_plugin/default_plugin.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gfx/gfx.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/net.gyp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thank you for fixing the dependency issue!

Expand Messages | Collapse Messages