Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/tab_contents/render_view_host_manager.cc

Issue 6106003: Similar as extension, DOM UI needs to be created in its own process.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/render_view_host_manager.cc
===================================================================
--- chrome/browser/tab_contents/render_view_host_manager.cc (revision 70598)
+++ chrome/browser/tab_contents/render_view_host_manager.cc (working copy)
@@ -298,6 +298,11 @@
// into the same process.
if (new_entry->url().SchemeIs(chrome::kExtensionScheme))
return true;
+ // When a tab is created, it starts as TYPE_NORMAL. If the new entry is a
+ // DOM UI page, it needs to run in a different process. This matches the
Charlie Reis 2011/01/06 18:27:59 Nit: "it needs to be grouped with other DOM UI pag
klobag.chromium 2011/01/06 20:23:02 Done.
+ // logic when transition between DOM UI and normal pages.
Charlie Reis 2011/01/06 18:27:59 Nit: transitioning
klobag.chromium 2011/01/06 20:23:02 Done.
+ if (new_entry->url().SchemeIs(chrome::kChromeUIScheme))
Charlie Reis 2011/01/06 18:27:59 I think we want to use DOMUIFactory::UseDOMUIForUR
klobag.chromium 2011/01/06 20:23:02 Done.
+ return true;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698