Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: chrome/browser/browsing_instance.cc

Issue 6106003: Similar as extension, DOM UI needs to be created in its own process.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_instance.cc
===================================================================
--- chrome/browser/browsing_instance.cc (revision 70598)
+++ chrome/browser/browsing_instance.cc (working copy)
@@ -34,6 +34,12 @@
return true;
}
+ if (url.SchemeIs(chrome::kChromeUIScheme)) {
Charlie Reis 2011/01/06 18:27:59 I think we may have had a bug before-- should this
klobag.chromium 2011/01/06 20:23:02 Done.
+ // Always consolidate instances of the new tab page (and instances of any
+ // other internal resource urls.
+ return true;
+ }
+
if (!command_line.HasSwitch(switches::kProcessPerTab)) {
// We are not in process-per-site or process-per-tab, so we must be in the
// default (process-per-site-instance). Only use the process-per-site
@@ -41,10 +47,6 @@
// Note that --single-process may have been specified, but that affects the
// process creation logic in RenderProcessHost, so we do not need to worry
// about it here.
Charlie Reis 2011/01/06 18:27:59 This comment and the one below assume that the pro
klobag.chromium 2011/01/06 20:23:02 Done.
Charlie Reis 2011/01/06 21:00:20 Actually, it looks like the comments are gone now.
- if (url.SchemeIs(chrome::kChromeUIScheme))
- // Always consolidate instances of the new tab page (and instances of any
- // other internal resource urls.
- return true;
// TODO(creis): List any other special cases that we want to limit to a
// single process for all instances.

Powered by Google App Engine
This is Rietveld 408576698