Issue 6104004: Fix errors in x64 crankshaft port, add failing tests to test expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6104004: Fix errors in x64 crankshaft port, add failing tests to test expectations. (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix errors in x64 crankshaft port, add failing tests to test expectations. Committed: http://code.google.com/p/v8/source/detail?r=6203

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -14 lines)			Patch
M	src/ia32/full-codegen-ia32.cc	View	1	4 chunks	+10 lines, -4 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	4 chunks	+37 lines, -9 lines	0 comments	Download
M	test/cctest/cctest.status	View	1	2 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM if you make the small change below (also on ia32). http://codereview.chromium.org/6104004/diff/1/src/x64/full-codegen-x64.cc File src/x64/full-codegen-x64.cc (right): ...

9 years, 11 months ago (2011-01-06 13:12:22 UTC) #2

William Hesse

9 years, 11 months ago (2011-01-06 13:26:02 UTC) #3

http://codereview.chromium.org/6104004/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):

http://codereview.chromium.org/6104004/diff/1/src/x64/full-codegen-x64.cc#new...
src/x64/full-codegen-x64.cc:1390: __
push(EmitSlotSearch(obj_proxy->var()->AsSlot(), rcx));
On 2011/01/06 13:12:22, Kevin Millikin wrote:
> I know this is a duplication of the code on ia32, but I'd prefer to have it
> written in both places as:
> 

Fixed all places here and on ia32.
> MemOperand slot_operand = EmitSlotSearch(...);
> __ push(slot_operand);
> 
> to be super careful about the side-effect of EmitSlotSearch (which may emit
> code).

Expand Messages | Collapse Messages