Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: chrome/browser/sync/sessions/status_controller_unittest.cc

Issue 6104003: sync: use progress markers instead of timestamps during GetUpdates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tim's fixes Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sessions/status_controller.cc ('k') | chrome/browser/sync/sessions/sync_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sessions/status_controller_unittest.cc
diff --git a/chrome/browser/sync/sessions/status_controller_unittest.cc b/chrome/browser/sync/sessions/status_controller_unittest.cc
index 88605bfb3f7891a96298b8c6c88d021fb826df7a..ba76f28a87d918097295fa5fcc0ce1f6956b845f 100644
--- a/chrome/browser/sync/sessions/status_controller_unittest.cc
+++ b/chrome/browser/sync/sessions/status_controller_unittest.cc
@@ -47,12 +47,6 @@ TEST_F(StatusControllerTest, GetsDirty) {
status.increment_num_consecutive_errors_by(0);
EXPECT_FALSE(status.TestAndClearIsDirty());
- {
- ScopedModelSafeGroupRestriction r(&status, GROUP_UI);
- status.set_current_download_timestamp(syncable::BOOKMARKS, 100);
- EXPECT_TRUE(status.TestAndClearIsDirty());
- }
-
status.set_num_server_changes_remaining(30);
EXPECT_TRUE(status.TestAndClearIsDirty());
@@ -130,12 +124,6 @@ TEST_F(StatusControllerTest, ReadYourWrites) {
status.increment_num_consecutive_errors_by(2);
EXPECT_EQ(11, status.error_counters().consecutive_errors);
- {
- ScopedModelSafeGroupRestriction r(&status, GROUP_UI);
- status.set_current_download_timestamp(syncable::BOOKMARKS, 12);
- EXPECT_EQ(12, status.ComputeMaxLocalTimestamp());
- }
-
status.set_num_server_changes_remaining(13);
EXPECT_EQ(13, status.num_server_changes_remaining());
@@ -226,7 +214,6 @@ TEST_F(StatusControllerTest, Unrestricted) {
status.error_counters();
status.syncer_status();
status.num_server_changes_remaining();
- status.ComputeMaxLocalTimestamp();
status.commit_ids();
status.HasBookmarkCommitActivity();
status.download_updates_succeeded();
« no previous file with comments | « chrome/browser/sync/sessions/status_controller.cc ('k') | chrome/browser/sync/sessions/sync_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698