sync: use progress markers instead of timestamps during GetUpdates

chrome/browser/sync/sessions/sync_session_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sessions/sync_session.h"
 
 #include "chrome/browser/sync/engine/conflict_resolver.h"
 #include "chrome/browser/sync/engine/syncer_types.h"
 #include "chrome/browser/sync/engine/syncer_util.h"
 #include "chrome/browser/sync/syncable/directory_manager.h"
 #include "chrome/browser/sync/syncable/syncable.h"
 #include "chrome/test/sync/engine/test_directory_setter_upper.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-using syncable::MultiTypeTimeStamp;
 using syncable::WriteTransaction;
 
 namespace browser_sync {
 namespace sessions {
 namespace {
 
 class SyncSessionTest : public testing::Test,
                         public SyncSession::Delegate,
                         public ModelSafeWorkerRegistrar {
  public:
   SyncSessionTest() : controller_invocations_allowed_(false) {
     GetModelSafeRoutingInfo(&routes_);
   }
 
   SyncSession* MakeSession() {
     return new SyncSession(context_.get(), this, SyncSourceInfo(), routes_,
                            std::vector<ModelSafeWorker*>());
-  }  
+  }
 
   virtual void SetUp() {
     context_.reset(new SyncSessionContext(NULL, NULL, this,
         std::vector<SyncEngineEventListener*>()));
     routes_.clear();
     routes_[syncable::BOOKMARKS] = GROUP_UI;
     routes_[syncable::AUTOFILL] = GROUP_UI;
     session_.reset(MakeSession());
   }
   virtual void TearDown() {
@@ skipping 26 matching lines @@
     out->swap(routes_);
   }
 
   StatusController* status() { return session_->status_controller(); }
  protected:
   void FailControllerInvocationIfDisabled(const std::string& msg) {
     if (!controller_invocations_allowed_)
       FAIL() << msg;
   }
 
-  MultiTypeTimeStamp ParamsMeaningAllEnabledTypes() {
-    MultiTypeTimeStamp request_params;
-    request_params.timestamp = 2000;
-    request_params.data_types[syncable::BOOKMARKS] = true;
-    request_params.data_types[syncable::AUTOFILL] = true;
+  syncable::ModelTypeBitSet ParamsMeaningAllEnabledTypes() {
+    syncable::ModelTypeBitSet request_params;
+    request_params[syncable::BOOKMARKS] = true;
+    request_params[syncable::AUTOFILL] = true;
     return request_params;
   }
 
-  MultiTypeTimeStamp ParamsMeaningJustOneEnabledType() {
-    MultiTypeTimeStamp request_params;
-    request_params.timestamp = 5000;
-    request_params.data_types[syncable::AUTOFILL] = true;
+  syncable::ModelTypeBitSet ParamsMeaningJustOneEnabledType() {
+    syncable::ModelTypeBitSet request_params;
+    request_params[syncable::AUTOFILL] = true;
     return request_params;
   }
 
   bool controller_invocations_allowed_;
   scoped_ptr<SyncSession> session_;
   scoped_ptr<SyncSessionContext> context_;
   ModelSafeRoutingInfo routes_;
 };
 
 TEST_F(SyncSessionTest, ScopedContextHelpers) {
@@ skipping 49 matching lines @@
 }
 
 TEST_F(SyncSessionTest, MoreToSyncIfConflictSetsBuilt) {
   // If we built conflict sets, then we need to loop back and try
   // to get updates & commit again.
   status()->update_conflict_sets_built(true);
   EXPECT_TRUE(session_->HasMoreToSync());
 }
 
 TEST_F(SyncSessionTest, MoreToDownloadIfDownloadFailed) {
-  status()->set_updates_request_parameters(ParamsMeaningAllEnabledTypes());
+  status()->set_updates_request_types(ParamsMeaningAllEnabledTypes());
 
   // When DownloadUpdatesCommand fails, these should be false.
   EXPECT_FALSE(status()->ServerSaysNothingMoreToDownload());
   EXPECT_FALSE(status()->download_updates_succeeded());
 
   // Download updates has its own loop in the syncer; it shouldn't factor
   // into HasMoreToSync.
   EXPECT_FALSE(session_->HasMoreToSync());
 }
 
-TEST_F(SyncSessionTest, MoreToDownloadIfGotTimestamp) {
-  status()->set_updates_request_parameters(ParamsMeaningAllEnabledTypes());
+TEST_F(SyncSessionTest, MoreToDownloadIfGotChangesRemaining) {
+  status()->set_updates_request_types(ParamsMeaningAllEnabledTypes());
 
-  // When the server returns a timestamp, that means there's more to download.
+  // When the server returns changes_remaining, that means there's
+  // more to download.
   status()->mutable_updates_response()->mutable_get_updates()
-      ->set_new_timestamp(1000000L);
+     ->set_changes_remaining(1000L);
   EXPECT_FALSE(status()->ServerSaysNothingMoreToDownload());
   EXPECT_TRUE(status()->download_updates_succeeded());
 
   // Download updates has its own loop in the syncer; it shouldn't factor
   // into HasMoreToSync.
   EXPECT_FALSE(session_->HasMoreToSync());
 }
 
-TEST_F(SyncSessionTest, MoreToDownloadIfGotNoTimestamp) {
-  status()->set_updates_request_parameters(ParamsMeaningAllEnabledTypes());
+TEST_F(SyncSessionTest, MoreToDownloadIfGotNoChangesRemaining) {
+  status()->set_updates_request_types(ParamsMeaningAllEnabledTypes());
 
   // When the server returns a timestamp, that means we're up to date.
   status()->mutable_updates_response()->mutable_get_updates()
-      ->clear_new_timestamp();
+      ->set_changes_remaining(0);
   EXPECT_TRUE(status()->ServerSaysNothingMoreToDownload());
   EXPECT_TRUE(status()->download_updates_succeeded());
 
   // Download updates has its own loop in the syncer; it shouldn't factor
   // into HasMoreToSync.
   EXPECT_FALSE(session_->HasMoreToSync());
 }
 
-TEST_F(SyncSessionTest, MoreToDownloadIfGotNoTimestampForSubset) {
-  status()->set_updates_request_parameters(ParamsMeaningJustOneEnabledType());
+TEST_F(SyncSessionTest, MoreToDownloadIfGotNoChangesRemainingForSubset) {
+  status()->set_updates_request_types(ParamsMeaningJustOneEnabledType());
 
   // When the server returns a timestamp, that means we're up to date for that
   // type.  But there may still be more to download if there are other
   // datatypes that we didn't request on this go-round.
   status()->mutable_updates_response()->mutable_get_updates()
-    ->clear_new_timestamp();
-  EXPECT_FALSE(status()->ServerSaysNothingMoreToDownload());
+      ->set_changes_remaining(0);
+
+  EXPECT_TRUE(status()->ServerSaysNothingMoreToDownload());
   EXPECT_TRUE(status()->download_updates_succeeded());
 
   // Download updates has its own loop in the syncer; it shouldn't factor
   // into HasMoreToSync.
   EXPECT_FALSE(session_->HasMoreToSync());
 }
 
-TEST_F(SyncSessionTest, MoreToDownloadIfGotTimestampAndEntries) {
-  status()->set_updates_request_parameters(ParamsMeaningAllEnabledTypes());
+TEST_F(SyncSessionTest, MoreToDownloadIfGotChangesRemainingAndEntries) {
+  status()->set_updates_request_types(ParamsMeaningAllEnabledTypes());
   // The actual entry count should not factor into the HasMoreToSync
   // determination.
   status()->mutable_updates_response()->mutable_get_updates()->add_entries();
   status()->mutable_updates_response()->mutable_get_updates()
-      ->set_new_timestamp(1000000L);;
+      ->set_changes_remaining(1000000L);;
   EXPECT_FALSE(status()->ServerSaysNothingMoreToDownload());
   EXPECT_TRUE(status()->download_updates_succeeded());
 
   // Download updates has its own loop in the syncer; it shouldn't factor
   // into HasMoreToSync.
   EXPECT_FALSE(session_->HasMoreToSync());
 }
 
+TEST_F(SyncSessionTest, MoreToDownloadIfGotNoChangesRemainingAndEntries) {
+  status()->set_updates_request_types(ParamsMeaningAllEnabledTypes());
+  // The actual entry count should not factor into the HasMoreToSync
+  // determination.
+  status()->mutable_updates_response()->mutable_get_updates()->add_entries();
+  status()->mutable_updates_response()->mutable_get_updates()
+      ->set_changes_remaining(0);
+  EXPECT_TRUE(status()->ServerSaysNothingMoreToDownload());
+  EXPECT_TRUE(status()->download_updates_succeeded());
+
+  // Download updates has its own loop in the syncer; it shouldn't factor
+  // into HasMoreToSync.
+  EXPECT_FALSE(session_->HasMoreToSync());
+}
 
 TEST_F(SyncSessionTest, MoreToSyncIfConflictsResolved) {
   // Conflict resolution happens after get updates and commit,
   // so we need to loop back and get updates / commit again now
   // that we have made forward progress.
   status()->update_conflicts_resolved(true);
   EXPECT_TRUE(session_->HasMoreToSync());
 }
 
 }  // namespace
 }  // namespace sessions
 }  // namespace browser_sync