Issue 6101006: Add StopInputMethodProcess API which allows Chrome to terminate ibus-daemon in a nicer way than kill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6101006: Add StopInputMethodProcess API which allows Chrome to terminate ibus-daemon in a nicer way than kill (Closed)

Created:
9 years, 11 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
ssh://git@gitrw.chromium.org:9222/cros.git@master

Visibility:
Public.

Description

Add StopInputMethodProcess API which allows Chrome/libcros to terminate ibus-daemon in a nicer way than the kill system call. Chrome part: http://codereview.chromium.org/6216002/ BUG=chromium-os:9685 TEST=manually Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=09abaf5

Patch Set 3 : review fix, add URL #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
M	chromeos_cros_api.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos_input_method.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos_input_method.cc	View	1 2	3 chunks	+30 lines, -0 lines	0 comments	Download
M	load.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

satorux1

LGTM http://codereview.chromium.org/6101006/diff/2001/chromeos_input_method.cc File chromeos_input_method.cc (right): http://codereview.chromium.org/6101006/diff/2001/chromeos_input_method.cc#newcode10 chromeos_input_method.cc:10: #if !IBUS_CHECK_VERSION(1, 3, 99) Having #ifdef is not ...

9 years, 11 months ago (2011-01-11 07:04:13 UTC) #2

Yusuke Sato

Filed crosbug.com/10838 and assigned it to me. The TODO comment is already there. Please check ...

9 years, 11 months ago (2011-01-11 07:33:00 UTC) #3

satorux1

9 years, 11 months ago (2011-01-11 08:15:37 UTC) #4

On 2011/01/11 07:33:00, Yusuke Sato wrote:
> Filed crosbug.com/10838 and assigned it to me.
> The TODO comment is already there. Please check the line 32:
> 
> > 32 // TODO(yusukes): Remove all code for ibus-1.3 once we finish migrating
to
> 1.4.

Nice. You could add a pointer to crosbug.com/10838 there. 

LGTM. Please submit.

Expand Messages | Collapse Messages

Issue 6101006: Add StopInputMethodProcess API which allows Chrome to terminate ibus-daemon in a nicer way than kill (Closed)

Description

Patch Set 1 : review #

Patch Set 2 : local rebase #

Patch Set 3 : review fix, add URL #

Messages