Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: test/mjsunit/bugs/bug-1015.js

Issue 6101001: Don't let JSON parsed objects hit inherited setters. (Closed)
Patch Set: Address review comments. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // See: http://code.google.com/p/v8/issues/detail?id=1015
29
30 // Object and array literals should be created using DefineOwnProperty, and
31 // therefore not hit setters in the prototype.
32
33 function mkFail(message) {
34 return function () { assertUnreachable(message); }
35 }
36
37 Object.defineProperty(Object.prototype, "foo",
38 {get: mkFail("oget"), set: mkFail("oset")});
39 Object.defineProperty(Array.prototype, "2",
40 {get: mkFail("aget"), set: mkFail("aset")});
41
42 function inFunction() {
43 for (var i = 0; i < 10; i++) {
44 // in loop.
45 var ja = JSON.parse('[1,2,3,4]');
46 var jo = JSON.parse('{"bar": 10, "foo": 20}')
47 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}')
48 var a = [1,2,3,4];
49 var o = { bar: 10, foo: 20 };
50 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } },
51 bar: 10 };
52 }
53 }
54
55 for (var i = 0; i < 10; i++) {
56 // In global scope.
57 var ja = JSON.parse('[1,2,3,4]');
58 var jo = JSON.parse('{"bar": 10, "foo": 20}')
59 var jop = JSON.parse('{"bar": 10, "__proto__": { }, "foo": 20}')
60 var a = [1,2,3,4];
61 var o = { bar: 10, foo: 20 };
62 var op = { __proto__: { set bar(v) { assertUnreachable("bset"); } },
63 bar: 10 };
64 // In function scope.
65 inFunction();
66 }
OLDNEW
« no previous file with comments | « src/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698