Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 6101001: Don't let JSON parsed objects hit inherited setters. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Don't let JSON parsed objects hit inherited setters.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -22 lines) Patch
M src/heap-inl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 chunks +12 lines, -5 lines 0 comments Download
M src/objects.cc View 1 7 chunks +23 lines, -15 lines 0 comments Download
M src/parser.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
A test/mjsunit/bugs/bug-1015.js View 1 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
9 years, 11 months ago (2011-01-04 09:37:24 UTC) #1
Rico
LGTM Consider renaming "own" to something else, like no_prototype_check or omit_prototype http://codereview.chromium.org/6101001/diff/1/src/api.cc File src/api.cc (right): ...
9 years, 11 months ago (2011-01-04 11:15:31 UTC) #2
Lasse Reichstein
Renamed own to check_prototype and reversed the logic. http://codereview.chromium.org/6101001/diff/1/src/api.cc File src/api.cc (right): http://codereview.chromium.org/6101001/diff/1/src/api.cc#newcode1 src/api.cc:1: Removed.
9 years, 11 months ago (2011-01-04 12:14:36 UTC) #3
Lasse Reichstein
9 years, 11 months ago (2011-01-04 12:17:28 UTC) #4
http://codereview.chromium.org/6101001/diff/1/test/mjsunit/bugs/bug-1015.js
File test/mjsunit/bugs/bug-1015.js (right):

http://codereview.chromium.org/6101001/diff/1/test/mjsunit/bugs/bug-1015.js#n...
test/mjsunit/bugs/bug-1015.js:44: // in loop.
Fixed all.

Powered by Google App Engine
This is Rietveld 408576698