Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 6100003: Update checks of multi-installs now use the proper app guid.... (Closed)

Created:
9 years, 11 months ago by grt (UTC plus 2)
Modified:
9 years, 7 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit, tommi (sloooow) - chröme
Visibility:
Public.

Description

Update checks of multi-installs now use the proper app guid. BUG=61609 TEST=install Chrome with --multi-install, monitor GoogleUpdate's log (e.g., via Sawbuck), and confirm that an update check uses the multi-installer package's app guid. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70623

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M chrome/browser/google/google_update.cc View 1 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/installer/util/helper.h View 1 3 chunks +7 lines, -1 line 0 comments Download
M chrome/installer/util/helper.cc View 1 3 chunks +12 lines, -1 line 0 comments Download
M chrome/installer/util/package_properties.h View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/installer/util/package_properties.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
9 years, 11 months ago (2011-01-06 14:56:51 UTC) #1
robertshield
On 2011/01/06 14:56:51, grt wrote: LGTM I find it the growing interface duplication between BrowserDistribution ...
9 years, 11 months ago (2011-01-06 15:36:43 UTC) #2
grt (UTC plus 2)
PackageProperties represents the package of files rather than one of the products. There is a ...
9 years, 11 months ago (2011-01-06 15:41:59 UTC) #3
grt (UTC plus 2)
PTAL
9 years, 11 months ago (2011-01-06 16:03:05 UTC) #4
robertshield
9 years, 11 months ago (2011-01-06 16:05:27 UTC) #5
On 2011/01/06 16:03:05, grt wrote:
> PTAL

Sure, lgtm

Powered by Google App Engine
This is Rietveld 408576698