Issue 6099016: Drastically reduce the number of redraws when editing content settings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6099016: Drastically reduce the number of redraws when editing content settings. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Drastically reduce the number of redraws when editing content settings. Using the debugger, I can verify that previously we were redrawing the entire list once per row (e.g. 10 times if you delete a row in a list that has 10 rows). Now it only redraws once for the delete. BUG=69086 TEST=see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71140

Patch Set 1 #

Total comments: 2

Patch Set 2 : add->set #

Patch Set 3 : fix selection bug #

Created: 9 years, 11 months ago

		Unified diffs	Side-by-side diffs	Stats (+15 lines, -19 lines)
	M	chrome/browser/resources/options/content_settings.js	View	2 chunks	+2 lines, -11 lines	0 comments
	M	chrome/browser/resources/options/content_settings_exceptions_area.js	View	2 chunks	+13 lines, -8 lines	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/6099016/diff/1/chrome/browser/resources/options/content_settings.js File chrome/browser/resources/options/content_settings.js (right): http://codereview.chromium.org/6099016/diff/1/chrome/browser/resources/options/content_settings.js#newcode102 chrome/browser/resources/options/content_settings.js:102: exceptionsList.addExceptions(list); You could also have used startBatchUpdates() and endBatchUpdates() ...

9 years, 11 months ago (2011-01-12 00:42:31 UTC) #2

Evan Stade

updated. Also changed addExceptions to setExceptions.

9 years, 11 months ago (2011-01-12 01:02:37 UTC) #3

LGTM

Expand Messages | Collapse Messages