Issue 6099013: Fix race condition where chrome.tabs.executeScript sometimes wouldn't

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6099013: Fix race condition where chrome.tabs.executeScript sometimes wouldn't (Closed)

Created:
9 years, 11 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix race condition where chrome.tabs.executeScript sometimes wouldn't inject scripts. This is done by reusing the same UserScriptIdleScheduler for reference fragment navigations. BUG=64093 TEST=See bug for repro. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71693

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : compile #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
M	chrome/renderer/navigation_state.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/navigation_state.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 2	3 chunks	+10 lines, -12 lines	0 comments	Download
M	chrome/renderer/user_script_idle_scheduler.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages