Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Issue 6098004: Integrate about:conflicts with --diagnostics... (Closed)

Created:
9 years, 11 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.
Visibility:
Public.

Description

Integrate about:conflicts with --diagnostics This should enable the user to find conflicting dlls that are crashing Chrome on startup. This changelist introduces a limited_mode for scanning, since the diagnostics tests run without the help of many Chrome services, so we can't use the File thread for asynchronous scanning or the notification system. Also changed the scanning so that if no signature/description is given in the blacklist, then we mark the DLL as a confirmed match if the name and the location match (before we used to match it as a 'suspected' match). A very sizable chunk of the blacklist is malware, which has no signature, so this gives us the ability to trigger the wrench badge on finding malware (that part remains opt-in through about:flags). Also added failure count to diagnostics output (sometimes the error scrolls off screen, so having a note at the bottom helps). BUG=51105 TEST=All diagnostics tests run as part of the unit tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70600

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -136 lines) Patch
M chrome/browser/diagnostics/diagnostics_main.cc View 5 chunks +17 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_model.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/diagnostics_model_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/diagnostics/diagnostics_test.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/diagnostics/recon_diagnostics.cc View 1 8 chunks +66 lines, -7 lines 0 comments Download
M chrome/browser/enumerate_modules_model_unittest_win.cc View 3 chunks +17 lines, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.h View 6 chunks +34 lines, -13 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 11 chunks +87 lines, -62 lines 0 comments Download
M chrome/browser/resources/about_conflicts.html View 1 chunk +39 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Carlos (hoping you are back), can you review: browser/diagnostics/diagnostics_main.cc browser/diagnostics/diagnostics_model.h browser/diagnostics/diagnostics_model.cc browser/diagnostics/diagnostics_test.h browser/diagnostics/recon_diagnostics.h browser/diagnostics/recon_diagnostics.cc Huan, ...
9 years, 11 months ago (2011-01-05 15:43:10 UTC) #1
huanr
On 2011/01/05 15:43:10, Finnur wrote: > Carlos (hoping you are back), can you review: > ...
9 years, 11 months ago (2011-01-05 20:47:54 UTC) #2
cpu_(ooo_6.6-7.5)
9 years, 11 months ago (2011-01-05 23:51:41 UTC) #3
lgtm on the 6 files as well.

On 2011/01/05 20:47:54, huanr wrote:
> On 2011/01/05 15:43:10, Finnur wrote:
> > Carlos (hoping you are back), can you review:
> > browser/diagnostics/diagnostics_main.cc	 
> > browser/diagnostics/diagnostics_model.h	 
> > browser/diagnostics/diagnostics_model.cc
> > browser/diagnostics/diagnostics_test.h	 
> > browser/diagnostics/recon_diagnostics.h	 
> > browser/diagnostics/recon_diagnostics.cc
> > 
> > Huan, can you review:
> > browser/enumerate_modules_model_unittest_win.cc	 
> > browser/enumerate_modules_model_win.h	 
> > browser/enumerate_modules_model_win.cc
> > browser/resources/about_conflicts.html
> 
> Reviewed these 4 files. LGTM.

Powered by Google App Engine
This is Rietveld 408576698