Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 6097010: Fix GC issue in instanceof stub... (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix GC issue in instanceof stub The the call of the builtin in InstanceofStub was not correctly protected with an internal frame leading to the return address being handled as a pointer during GC. Marked the Instanceof stub as allowing stub calls (the RecordWriteStub was removed some days ago). This issue was not caught by the assertion designed for this when debug mode is run with --debug-code (which out tests always does) as generating code for Abort set the allow stub calls flag to true. This has been fixed by restoring the allow stub calls flag correctly. Committed: http://code.google.com/p/v8/source/detail?r=6218

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 5 chunks +21 lines, -4 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-07 09:34:17 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-07 10:24:10 UTC) #2
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698